From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] cache align qdisc data
Date: Tue, 03 Aug 2004 21:17:49 +0200 [thread overview]
Message-ID: <410FE4DD.5000306@trash.net> (raw)
In-Reply-To: <20040803083820.711c917c@dell_ss3.pdx.osdl.net>
Stephen Hemminger wrote:
>This patch has qdisc code use the same interface as the netdevice code
>to cache align the object private data.
>
>
These two hunks look bogus.
>diff -Nru a/net/sched/sch_hfsc.c b/net/sched/sch_hfsc.c
>--- a/net/sched/sch_hfsc.c 2004-07-27 11:03:02 -07:00
>+++ b/net/sched/sch_hfsc.c 2004-07-27 11:03:02 -07:00
>@@ -1554,7 +1554,6 @@
> qopt = RTA_DATA(opt);
>
> memset(q, 0, sizeof(struct hfsc_sched));
>- sch->stats_lock = &sch->dev->queue_lock;
>
> q->defcls = qopt->defcls;
> for (i = 0; i < HFSC_HSIZE; i++)
>
>@@ -1674,7 +1673,7 @@
> RTA_PUT(skb, TCA_OPTIONS, sizeof(qopt), &qopt);
>
> sch->stats.qlen = sch->q.qlen;
>- if (qdisc_copy_stats(skb, &sch->stats, sch->stats_lock) < 0)
>+ if (qdisc_copy_stats(skb, &sch->stats, &sch->dev->queue_lock) < 0)
> goto rtattr_failure;
>
> return skb->len;
>
>
next prev parent reply other threads:[~2004-08-03 19:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 15:24 [PATCH 2.6 3/5]: Use double-linked list for dev->qdisc_list Patrick McHardy
2004-08-03 15:35 ` Stephen Hemminger
2004-08-03 19:22 ` Patrick McHardy
2004-08-03 15:38 ` [PATCH 2.6] cache align qdisc data Stephen Hemminger
2004-08-03 19:17 ` Patrick McHardy [this message]
2004-08-03 20:31 ` Stephen Hemminger
2004-08-03 20:42 ` Patrick McHardy
2004-08-03 21:05 ` Stephen Hemminger
2004-08-04 16:51 ` David S. Miller
2004-08-04 16:43 ` [PATCH 2.6 3/5]: Use double-linked list for dev->qdisc_list David S. Miller
2004-08-04 19:55 ` Patrick McHardy
2004-08-04 20:43 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410FE4DD.5000306@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).