From: Ben Greear <greearb@candelatech.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] vlan - device refcount bug.
Date: Tue, 03 Aug 2004 13:36:16 -0700 [thread overview]
Message-ID: <410FF740.5060903@candelatech.com> (raw)
In-Reply-To: <20040803131425.503f8f45@dell_ss3.pdx.osdl.net>
Stephen Hemminger wrote:
> If you rmmod a network device that is in a vlan, the system hangs waiting
> for the refcount to go to zero, because it is -1. The problem is that the
> vlan notifier does an extra dev_put in NETDEV_UNREGISTER case of notifier.
Good catch. It would seem to me that it would be good to have a
BUG() or similar to catch any instance of the reference count going
negative.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2004-08-03 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 20:14 [PATCH 2.6] vlan - device refcount bug Stephen Hemminger
2004-08-03 20:36 ` Ben Greear [this message]
2004-08-09 23:49 ` David S. Miller
2004-08-09 23:49 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=410FF740.5060903@candelatech.com \
--to=greearb@candelatech.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).