From: Patrick McHardy <kaber@trash.net>
To: Tomasz Paszkowski <tomasz.paszkowski@e-wro.pl>
Cc: davem@redhat.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.4] Use double-linked list for dev->qdisc_list
Date: Wed, 04 Aug 2004 15:30:45 +0200 [thread overview]
Message-ID: <4110E505.1010205@trash.net> (raw)
In-Reply-To: <20040804125926.GA15324@krezus.e-wro.net>
Tomasz Paszkowski wrote:
>This patch changes dev->qdisc_list to a double-linked list. This solves
>the performance problems when destroying qdiscs with large number of inner
>qdiscs.
>
>This is backported version of Patrick McHardy patch (03-qdisc_list-list_h.diff)
>or 2.6 kernels.
>
>
Looks good, except for the last hunk, the BUG_TRAP is valid in 2.4 because
it doesn't use RCU. Change it to BUG_TRAP(list_empty(&dev->qdisc_list)).
>
>
>------------------------------------------------------------------------
>
> #endif
>- BUG_TRAP(dev->qdisc_list == NULL);
> BUG_TRAP(!timer_pending(&dev->watchdog_timer));
>- dev->qdisc_list = NULL;
> spin_unlock_bh(&dev->queue_lock);
> write_unlock(&qdisc_tree_lock);
> }
>
>
next prev parent reply other threads:[~2004-08-04 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-04 12:59 [PATCH 2.4] Use double-linked list for dev->qdisc_list Tomasz Paszkowski
2004-08-04 13:30 ` Patrick McHardy [this message]
2004-08-04 14:56 ` Tomasz Paszkowski
2004-08-04 20:44 ` David S. Miller
2004-08-04 21:50 ` Patrick McHardy
2004-08-14 8:17 ` Patrick McHardy
2004-08-18 20:10 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4110E505.1010205@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=tomasz.paszkowski@e-wro.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).