From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 1/5]: Fix locking in __qdisc_destroy rcu-callback
Date: Wed, 04 Aug 2004 21:53:28 +0200 [thread overview]
Message-ID: <41113EB8.6000809@trash.net> (raw)
In-Reply-To: <20040804093328.4ee56d30.davem@redhat.com>
David S. Miller wrote:
>On Tue, 03 Aug 2004 17:20:36 +0200
>Patrick McHardy <kaber@trash.net> wrote:
>
>
>>I'm not sure if RCU callback can be scheduled while the kernel is
>>
>>running in process context, so this may be unneccessary.
>>
>>
>
>RCU callbacks run via tasklets, and thus in softirq context,
>thus your locking changes to _bh() are indeed necessary.
>
>
I meant because in my understanding of RCU the quintescent state is
not reached while the CPU is running kernel code, so the callback can't
be scheduled. A previously scheduled callback should finish before
further kernel code is run in process context.
Regards
Patrick
prev parent reply other threads:[~2004-08-04 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-03 15:20 [PATCH 2.6 1/5]: Fix locking in __qdisc_destroy rcu-callback Patrick McHardy
2004-08-04 16:33 ` David S. Miller
2004-08-04 19:53 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41113EB8.6000809@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).