From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter
Date: Sun, 08 Aug 2004 16:53:18 +0200 [thread overview]
Message-ID: <41163E5E.8060004@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 59 bytes --]
I missed this one when fixing locking in __qdisc_destroy.
[-- Attachment #2: tc_dump_tfilter-bh.diff --]
[-- Type: text/x-patch, Size: 988 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/08/08 14:15:49+02:00 kaber@kaber.coreworks.de
# [PKT_SCHED]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/sched/cls_api.c
# 2004/08/08 14:15:30+02:00 kaber@kaber.coreworks.de +2 -2
# [PKT_SCHED]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter
#
diff -Nru a/net/sched/cls_api.c b/net/sched/cls_api.c
--- a/net/sched/cls_api.c 2004-08-08 14:17:46 +02:00
+++ b/net/sched/cls_api.c 2004-08-08 14:17:46 +02:00
@@ -387,7 +387,7 @@
if ((dev = dev_get_by_index(tcm->tcm_ifindex)) == NULL)
return skb->len;
- read_lock(&qdisc_tree_lock);
+ read_lock_bh(&qdisc_tree_lock);
if (!tcm->tcm_parent)
q = dev->qdisc_sleeping;
else
@@ -444,7 +444,7 @@
if (cl)
cops->put(q, cl);
out:
- read_unlock(&qdisc_tree_lock);
+ read_unlock_bh(&qdisc_tree_lock);
dev_put(dev);
return skb->len;
}
next reply other threads:[~2004-08-08 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 14:53 Patrick McHardy [this message]
2004-08-10 0:05 ` [PATCH]: Disable local bh's when grabing qdisc_tree_lock in tc_dump_tfilter David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41163E5E.8060004@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).