From: Michal Schmidt <xschmi00@stud.feec.vutbr.cz>
To: achirica@ttd.net
Cc: netdev@oss.sgi.com
Subject: [PATCH] airo.c - don't clear FLAG_RADIO_DOWN on resume
Date: Fri, 13 Aug 2004 00:25:06 +0200 [thread overview]
Message-ID: <411BEE42.4050806@stud.feec.vutbr.cz> (raw)
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
Hello,
According to comments in airo.c the flag FLAG_RADIO_DOWN means:
Radio disabled via "ifconfig ethX down".
airo_pci_resume clears this flag.
This causes a little problem I can reproduce on my IBM ThinkPad R40 with
Cisco Aironet mini-PCI card (MPI350) with these steps:
1) ifup eth0 => card works OK, radio status LED indicator is on
2) ifdown eth0 => LED turns off
3) hibernate using swsuspend
4) resume from swsuspend
Result: interface eth0 is down, but the LED indicates that radio is on.
Expected result: interface eth0 is down, so the radio should be off.
I think that airo_pci_resume shouldn't mess with FLAG_RADIO_DOWN. I have
removed the line and now everything works as expected. One-line patch
attached.
Michal Schmidt
[-- Attachment #2: airo-resume-radio.patch --]
[-- Type: text/x-patch, Size: 485 bytes --]
--- linux-2.6.8-rc4-bk2/drivers/net/wireless/airo.c 2004-08-12 22:00:42.000000000 +0200
+++ linux-2.6.8-rc4-bk2-mich/drivers/net/wireless/airo.c 2004-08-12 22:09:15.000000000 +0200
@@ -5520,7 +5520,6 @@ static int airo_pci_resume(struct pci_de
mpi_init_descriptors(ai);
setup_card(ai, dev->dev_addr, 0);
clear_bit(FLAG_RADIO_OFF, &ai->flags);
- clear_bit(FLAG_RADIO_DOWN, &ai->flags);
clear_bit(FLAG_PENDING_XMIT, &ai->flags);
} else {
OUT4500(ai, EVACK, EV_AWAKEN);
reply other threads:[~2004-08-12 22:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=411BEE42.4050806@stud.feec.vutbr.cz \
--to=xschmi00@stud.feec.vutbr.cz \
--cc=achirica@ttd.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).