From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CC2D1F7060 for ; Tue, 3 Dec 2024 14:38:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236693; cv=none; b=SwZB6AoIqy+MJev+Zsb8UYKWpQRVAbSHiqHZyIwyGqhq91y12WeBc1DIDYCVu3mNWBuVixoxV32XjlNJP5whSj1h2ETi9YuH8pixBnfZdXIRg6BvOthTAP/lxNEIG/Z/6JlH3XmpaxUPARxvAVJGcF5s1G7CeaJHsEFkIYkqDXQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733236693; c=relaxed/simple; bh=1xSwGntOs483IXpes9RE41VqWC/DkA82mYEGpp84DXE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G8euTvTEqpIHj4Xn0piqNUgsi2EAG6qAJ7p4i5cO8cj/eAmmX1tc+y0v3JtpajlHkANKoZ5hgztK2c/TfvjmofNNc+l2swaMW4xPf+2V+a/b6QEDzumwx3ICKd4I5HFtKoRzQ7CQBANi8UoXurYUj8TlyKS27ey/RdMkCMKKs7E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net; spf=pass smtp.mailfrom=openvpn.com; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b=dbfc73WQ; arc=none smtp.client-ip=209.85.218.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=openvpn.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=openvpn.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=openvpn.net header.i=@openvpn.net header.b="dbfc73WQ" Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-aa503cced42so824554466b.3 for ; Tue, 03 Dec 2024 06:38:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=openvpn.net; s=google; t=1733236690; x=1733841490; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=AcMk8p/L4xS8bpKaq3E7c7KWsNOhXEOOyWlE091hFNk=; b=dbfc73WQfd5MtO4Nr14caIpbEltoWwNM1OxdNZKAW6Ig3e5eNg9tvJH9e1SXhrUTll fifNX/Xj/eMVh57Smdws9oqDgTKjg7KZVXhrDdmPv+A4KoztFxzQeA8MQyxifmvtZKZ8 IbJhDSYECQu6vGbpWFg4OrBWrxAe2difUcS2A5kJBDR5COLVvYv7hCJtUyXHKFRHz7LV V83HkBfxsGB9OMgPN33dqbGhtscx7tss5kjHMawx7YL7GFFpysMUo9hx9+HVKJne3Gf/ s1z46ayGsq0zmx+KLsmfz0XEze8hLmRdI9GZEdxssuqqXC+qnmeX0og84ypBXMA41Yik fAcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733236690; x=1733841490; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AcMk8p/L4xS8bpKaq3E7c7KWsNOhXEOOyWlE091hFNk=; b=v0p9xYTSo/8gYKSMO6JQpwdPIWPeb+HMaXe2IC932XrszbgJZwaUc4E5Z4LztyaKnW aVtnFMJTl/w+jkHZP901/c59qRu4IDZrBZ1Sf7+O+ZuMIv9V8NB1SNPTSxVtvWhCufiq mLeRtlSkC1zVn+RVBV1qMH85b/+j55PSrBdybOZYsu5gTLBC3+xJ1QDgr0VrTPgZR0rh pu6N08CCWm/oszmlYmiLIdiU+nDwx6vl/9zGqoKkqliruz9WPZ4u61xZ4xndFaqrktzZ uh8vEJa0EsT5hV4sfFgpH0iAvBjLOs+FSCjyG7GnW/0HXYnx/64hHn4X9cNLiKzN3Y4j NYbw== X-Forwarded-Encrypted: i=1; AJvYcCW4/kF3pipRmNqtIeXvUuArz4z48IHRx/BW58TCVri2DvzPC7Dk7aDhXuyyOL1hwDsbJH7PMnA=@vger.kernel.org X-Gm-Message-State: AOJu0YyYs3sQXPi0JL802JftDPgOGrKSwjJt3jOHP2EODBVM9Coe+tW7 lFw5fvAiLmhLxX+/LGnd2bl97kqOztDEdtWHFUb5jFGUaYnxUWQfb86pH26ioUk= X-Gm-Gg: ASbGncv+AuLthwGruch44y7cFXv+1vTOy9R18u/nR5QUG/Mod8OyN7P3riVylJxnJq9 aWAT8Pqw75DxZvz9G86yM4l5sgPgRLzD2sTAVVFPeSnQYeez7dvij5sMgF/bRCoNHMeXUK0ff9u YiznfcbYUVYzAcFE2G7lYmDlTjD3l8L5oEnHuA/u/uXzj97GhJrSaraK84wjQEiWMWvDSa5tkjP fR6cN0wdp09aWfAHYvMavq705b5z5eSoeh7IHtG7tIozYAKoQCkWsrrxnxPd8YVYuCB7TyKdD84 MCYzo3ld8JN7 X-Google-Smtp-Source: AGHT+IHXMgrAw8DvP9mNiokY+5wRvDcA6G6RMXPkdhouMrvAnOORvb3XV1avC+WUIz9UgC2FTICSrA== X-Received: by 2002:a17:906:3151:b0:aa5:3853:5541 with SMTP id a640c23a62f3a-aa5f7f0b007mr188305766b.41.1733236689712; Tue, 03 Dec 2024 06:38:09 -0800 (PST) Received: from ?IPV6:2001:67c:2fbc:1:138c:c1e3:75bf:72b5? ([2001:67c:2fbc:1:138c:c1e3:75bf:72b5]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa599953c81sm624432466b.184.2024.12.03.06.38.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Dec 2024 06:38:09 -0800 (PST) Message-ID: <411ee201-4248-4452-af00-0b2d2eca4369@openvpn.net> Date: Tue, 3 Dec 2024 15:38:48 +0100 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v12 08/22] ovpn: implement basic RX path (UDP) To: Paolo Abeni Cc: Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Eric Dumazet , Jakub Kicinski , Donald Hunter , Shuah Khan , sd@queasysnail.net, ryazanov.s.a@gmail.com, Andrew Lunn References: <20241202-b4-ovpn-v12-0-239ff733bf97@openvpn.net> <20241202-b4-ovpn-v12-8-239ff733bf97@openvpn.net> Content-Language: en-US From: Antonio Quartulli Autocrypt: addr=antonio@openvpn.net; keydata= xsFNBFN3k+ABEADEvXdJZVUfqxGOKByfkExNpKzFzAwHYjhOb3MTlzSLlVKLRIHxe/Etj13I X6tcViNYiIiJxmeHAH7FUj/yAISW56lynAEt7OdkGpZf3HGXRQz1Xi0PWuUINa4QW+ipaKmv voR4b1wZQ9cZ787KLmu10VF1duHW/IewDx9GUQIzChqQVI3lSHRCo90Z/NQ75ZL/rbR3UHB+ EWLIh8Lz1cdE47VaVyX6f0yr3Itx0ZuyIWPrctlHwV5bUdA4JnyY3QvJh4yJPYh9I69HZWsj qplU2WxEfM6+OlaM9iKOUhVxjpkFXheD57EGdVkuG0YhizVF4p9MKGB42D70pfS3EiYdTaKf WzbiFUunOHLJ4hyAi75d4ugxU02DsUjw/0t0kfHtj2V0x1169Hp/NTW1jkqgPWtIsjn+dkde dG9mXk5QrvbpihgpcmNbtloSdkRZ02lsxkUzpG8U64X8WK6LuRz7BZ7p5t/WzaR/hCdOiQCG RNup2UTNDrZpWxpwadXMnJsyJcVX4BAKaWGsm5IQyXXBUdguHVa7To/JIBlhjlKackKWoBnI Ojl8VQhVLcD551iJ61w4aQH6bHxdTjz65MT2OrW/mFZbtIwWSeif6axrYpVCyERIDEKrX5AV rOmGEaUGsCd16FueoaM2Hf96BH3SI3/q2w+g058RedLOZVZtyQARAQABzSdBbnRvbmlvIFF1 YXJ0dWxsaSA8YW50b25pb0BvcGVudnBuLm5ldD7Cwa0EEwEIAFcCGwMFCwkIBwMFFQoJCAsF FgIDAQACHgECF4AFCRWQ2TIWIQTKvaEoIBfCZyGYhcdI8My2j1nRTAUCYRUquBgYaGtwczov L2tleXMub3BlbnBncC5vcmcACgkQSPDMto9Z0UzmcxAAjzLeD47We0R4A/14oDKlZxXO0mKL fCzaWFsdhQCDhZkgxoHkYRektK2cEOh4Vd+CnfDcPs/iZ1i2+Zl+va79s4fcUhRReuwi7VCg 7nHiYSNC7qZo84Wzjz3RoGYyJ6MKLRn3zqAxUtFECoS074/JX1sLG0Z3hi19MBmJ/teM84GY IbSvRwZu+VkJgIvZonFZjbwF7XyoSIiEJWQC+AKvwtEBNoVOMuH0tZsgqcgMqGs6lLn66RK4 tMV1aNeX6R+dGSiu11i+9pm7sw8tAmsfu3kQpyk4SB3AJ0jtXrQRESFa1+iemJtt+RaSE5LK 5sGLAO+oN+DlE0mRNDQowS6q/GBhPCjjbTMcMfRoWPCpHZZfKpv5iefXnZ/xVj7ugYdV2T7z r6VL2BRPNvvkgbLZgIlkWyfxRnGh683h4vTqRqTb1wka5pmyBNAv7vCgqrwfvaV1m7J9O4B5 PuRjYRelmCygQBTXFeJAVJvuh2efFknMh41R01PP2ulXAQuVYEztq3t3Ycw6+HeqjbeqTF8C DboqYeIM18HgkOqRrn3VuwnKFNdzyBmgYh/zZx/dJ3yWQi/kfhR6TawAwz6GdbQGiu5fsx5t u14WBxmzNf9tXK7hnXcI24Z1z6e5jG6U2Swtmi8sGSh6fqV4dBKmhobEoS7Xl496JN2NKuaX jeWsF2rOwE0EZmhJFwEIAOAWiIj1EYkbikxXSSP3AazkI+Y/ICzdFDmiXXrYnf/mYEzORB0K vqNRQOdLyjbLKPQwSjYEt1uqwKaD1LRLbA7FpktAShDK4yIljkxhvDI8semfQ5WE/1Jj/I/Q U+4VXhkd6UvvpyQt/LiWvyAfvExPEvhiMnsg2zkQbBQ/M4Ns7ck0zQ4BTAVzW/GqoT2z03mg p1FhxkfzHMKPQ6ImEpuY5cZTQwrBUgWif6HzCtQJL7Ipa2fFnDaIHQeiJG0RXl/g9x3YlwWG sxOFrpWWsh6GI0Mo2W2nkinEIts48+wNDBCMcMlOaMYpyAI7fT5ziDuG2CBA060ZT7qqdl6b aXUAEQEAAcLBfAQYAQgAJhYhBMq9oSggF8JnIZiFx0jwzLaPWdFMBQJmaEkXAhsMBQkB4TOA AAoJEEjwzLaPWdFMbRUP/0t5FrjF8KY6uCU4Tx029NYKDN9zJr0CVwSGsNfC8WWonKs66QE1 pd6xBVoBzu5InFRWa2ed6d6vBw2BaJHC0aMg3iwwBbEgPn4Jx89QfczFMJvFm+MNc2DLDrqN zaQSqBzQ5SvUjxh8lQ+iqAhi0MPv4e2YbXD0ROyO+ITRgQVZBVXoPm4IJGYWgmVmxP34oUQh BM7ipfCVbcOFU5OPhd9/jn1BCHzir+/i0fY2Z/aexMYHwXUMha/itvsBHGcIEYKk7PL9FEfs wlbq+vWoCtUTUc0AjDgB76AcUVxxJtxxpyvES9aFxWD7Qc+dnGJnfxVJI0zbN2b37fX138Bf 27NuKpokv0sBnNEtsD7TY4gBz4QhvRNSBli0E5bGUbkM31rh4Iz21Qk0cCwR9D/vwQVsgPvG ioRqhvFWtLsEt/xKolOmUWA/jP0p8wnQ+3jY6a/DJ+o5LnVFzFqbK3fSojKbfr3bY33iZTSj DX9A4BcohRyqhnpNYyHL36gaOnNnOc+uXFCdoQkI531hXjzIsVs2OlfRufuDrWwAv+em2uOT BnRX9nFx9kPSO42TkFK55Dr5EDeBO3v33recscuB8VVN5xvh0GV57Qre+9sJrEq7Es9W609a +M0yRJWJEjFnMa/jsGZ+QyLD5QTL6SGuZ9gKI3W1SfFZOzV7hHsxPTZ6 Organization: OpenVPN Inc. In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/12/2024 15:34, Paolo Abeni wrote: [...] >> +static void ovpn_netdev_write(struct ovpn_peer *peer, struct sk_buff *skb) >> +{ >> + unsigned int pkt_len; >> + int ret; >> + >> + /* we can't guarantee the packet wasn't corrupted before entering the >> + * VPN, therefore we give other layers a chance to check that >> + */ >> + skb->ip_summed = CHECKSUM_NONE; >> + >> + /* skb hash for transport packet no longer valid after decapsulation */ >> + skb_clear_hash(skb); >> + >> + /* post-decrypt scrub -- prepare to inject encapsulated packet onto the >> + * interface, based on __skb_tunnel_rx() in dst.h >> + */ >> + skb->dev = peer->ovpn->dev; >> + skb_set_queue_mapping(skb, 0); >> + skb_scrub_packet(skb, true); >> + >> + skb_reset_network_header(skb); >> + skb_reset_transport_header(skb); >> + skb_probe_transport_header(skb); > > This is a no-op after the previous call. You should drop it. Thanks Paolo, I'll drop it. Regards, -- Antonio Quartulli OpenVPN Inc.