From: Oliver Neukum <oneukum@suse.de>
To: Hemant Kumar <hemantk@codeaurora.org>
Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] net: usb: Fix memory leak on Tx data path
Date: Fri, 26 Oct 2012 09:39:16 +0200 [thread overview]
Message-ID: <4122165.gxBpJlT6o2@linux-lqwf.site> (raw)
In-Reply-To: <1351225074-2078-1-git-send-email-hemantk@codeaurora.org>
On Thursday 25 October 2012 21:17:54 Hemant Kumar wrote:
> Driver anchors the tx urbs and defers the urb submission if
> a transmit request comes when the interface is suspended.
> Anchoring urb increments the urb reference count. These
> deferred urbs are later accessed by calling usb_get_from_anchor()
> for submission during interface resume. usb_get_from_anchor()
> unanchors the urb but urb reference count remains same.
> This causes the urb reference count to remain non-zero
> after usb_free_urb() gets called and urb never gets freed.
> Hence call usb_put_urb() after anchoring the urb to properly
> balance the reference count for these deferred urbs. Also,
> unanchor these deferred urbs during disconnect, to free them
> up.
Good catch. This needs to go into stable, too.
>
> Signed-off-by: Hemant Kumar <hemantk@codeaurora.org>
Acked-by: Oliver Neukum <oneukum@suse.de>
Regards
Oliver
next prev parent reply other threads:[~2012-10-26 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 4:17 [PATCH] net: usb: Fix memory leak on Tx data path Hemant Kumar
2012-10-26 7:39 ` Oliver Neukum [this message]
2012-10-26 7:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4122165.gxBpJlT6o2@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).