From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: [PATCH] net: usb: Fix memory leak on Tx data path Date: Fri, 26 Oct 2012 09:39:16 +0200 Message-ID: <4122165.gxBpJlT6o2@linux-lqwf.site> References: <1351225074-2078-1-git-send-email-hemantk@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: gregkh@linuxfoundation.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org To: Hemant Kumar Return-path: In-Reply-To: <1351225074-2078-1-git-send-email-hemantk@codeaurora.org> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thursday 25 October 2012 21:17:54 Hemant Kumar wrote: > Driver anchors the tx urbs and defers the urb submission if > a transmit request comes when the interface is suspended. > Anchoring urb increments the urb reference count. These > deferred urbs are later accessed by calling usb_get_from_anchor() > for submission during interface resume. usb_get_from_anchor() > unanchors the urb but urb reference count remains same. > This causes the urb reference count to remain non-zero > after usb_free_urb() gets called and urb never gets freed. > Hence call usb_put_urb() after anchoring the urb to properly > balance the reference count for these deferred urbs. Also, > unanchor these deferred urbs during disconnect, to free them > up. Good catch. This needs to go into stable, too. > > Signed-off-by: Hemant Kumar Acked-by: Oliver Neukum Regards Oliver