From: Jeff Garzik <jgarzik@pobox.com>
To: tgraf@suug.ch, davem@redhat.com
Cc: Netdev <netdev@oss.sgi.com>
Subject: Re: [NET]: Device mtu/txqlen/ifmap via rtnetlink.
Date: Thu, 26 Aug 2004 02:29:03 -0400 [thread overview]
Message-ID: <412D832F.2070003@pobox.com> (raw)
In-Reply-To: <200408260506.i7Q56Ebq022683@hera.kernel.org>
Linux Kernel Mailing List wrote:
> @@ -246,6 +268,30 @@
>
> err = -EINVAL;
>
> + if (ifm->ifi_flags)
> + dev_change_flags(dev, ifm->ifi_flags);
> +
> + if (ida[IFLA_MAP - 1]) {
> + if (!dev->set_config) {
> + err = -EOPNOTSUPP;
> + goto out;
> + }
> +
> + if (!netif_device_present(dev)) {
> + err = -ENODEV;
> + goto out;
> + }
> +
> + if (ida[IFLA_MAP - 1]->rta_len != RTA_LENGTH(sizeof(struct ifmap)))
> + goto out;
> +
> + err = dev->set_config(dev, (struct ifmap *)
> + RTA_DATA(ida[IFLA_MAP - 1]));
> +
> + if (err)
> + goto out;
> + }
> +
Why are new calls to deprecated hook ->set_config() being added?
Jeff
next parent reply other threads:[~2004-08-26 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200408260506.i7Q56Ebq022683@hera.kernel.org>
2004-08-26 6:29 ` Jeff Garzik [this message]
2004-08-26 6:33 ` [NET]: Device mtu/txqlen/ifmap via rtnetlink David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=412D832F.2070003@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).