* Re: [NET]: Device mtu/txqlen/ifmap via rtnetlink.
[not found] <200408260506.i7Q56Ebq022683@hera.kernel.org>
@ 2004-08-26 6:29 ` Jeff Garzik
2004-08-26 6:33 ` David S. Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Garzik @ 2004-08-26 6:29 UTC (permalink / raw)
To: tgraf, davem; +Cc: Netdev
Linux Kernel Mailing List wrote:
> @@ -246,6 +268,30 @@
>
> err = -EINVAL;
>
> + if (ifm->ifi_flags)
> + dev_change_flags(dev, ifm->ifi_flags);
> +
> + if (ida[IFLA_MAP - 1]) {
> + if (!dev->set_config) {
> + err = -EOPNOTSUPP;
> + goto out;
> + }
> +
> + if (!netif_device_present(dev)) {
> + err = -ENODEV;
> + goto out;
> + }
> +
> + if (ida[IFLA_MAP - 1]->rta_len != RTA_LENGTH(sizeof(struct ifmap)))
> + goto out;
> +
> + err = dev->set_config(dev, (struct ifmap *)
> + RTA_DATA(ida[IFLA_MAP - 1]));
> +
> + if (err)
> + goto out;
> + }
> +
Why are new calls to deprecated hook ->set_config() being added?
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-26 6:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200408260506.i7Q56Ebq022683@hera.kernel.org>
2004-08-26 6:29 ` [NET]: Device mtu/txqlen/ifmap via rtnetlink Jeff Garzik
2004-08-26 6:33 ` David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).