netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Changli Gao <xiaosuo@gmail.com>
To: Tom Herbert <therbert@google.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
	bhutchings@solarflare.com, shemminger@vyatta.com,
	eric.dumazet@gmail.com
Subject: Re: [PATCH v6] rps: Receive Packet Steering
Date: Thu, 11 Mar 2010 17:45:18 +0800	[thread overview]
Message-ID: <412e6f7f1003110145o48014e57q79e78ac3b8898c1c@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.1003102249380.21248@pokey.mtv.corp.google.com>

On Thu, Mar 11, 2010 at 3:00 PM, Tom Herbert <therbert@google.com> wrote:
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 93c4e06..472c767 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -581,6 +581,7 @@ static struct sk_buff *__skb_clone(struct sk_buff *n, struct sk_buff *skb)
>        C(len);
>        C(data_len);
>        C(mac_len);
> +       C(rxhash);
>        n->hdr_len = skb->nohdr ? skb_headroom(skb) : skb->hdr_len;
>        n->cloned = 1;
>        n->nohdr = 0;

Why not do the same thing in function __copy_skb_header()?

-- 
Regards,
Changli Gao(xiaosuo@gmail.com)

  reply	other threads:[~2010-03-11  9:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-11  7:00 [PATCH v6] rps: Receive Packet Steering Tom Herbert
2010-03-11  9:45 ` Changli Gao [this message]
2010-03-11 14:45 ` Eric Dumazet
2010-03-11 17:11   ` Tom Herbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=412e6f7f1003110145o48014e57q79e78ac3b8898c1c@mail.gmail.com \
    --to=xiaosuo@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).