From: Jacob Keller <jacob.e.keller@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>, <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<horms@kernel.org>
Subject: Re: [net PATCH v2 8/8] fbnic: Do not allow mailbox to toggle to ready outside fbnic_mbx_poll_tx_ready
Date: Tue, 6 May 2025 11:57:46 -0700 [thread overview]
Message-ID: <41334bc0-4ea5-4bf6-a5c3-9726fccfd5f8@intel.com> (raw)
In-Reply-To: <174654722518.499179.11612865740376848478.stgit@ahduyck-xeon-server.home.arpa>
On 5/6/2025 9:00 AM, Alexander Duyck wrote:
> From: Alexander Duyck <alexanderduyck@fb.com>
>
> We had originally thought to have the mailbox go to ready in the background
> while we were doing other things. One issue with this though is that we
> can't disable it by clearing the ready state without also blocking
> interrupts or calls to mbx_poll as it will just pop back to life during an
> interrupt.
>
> In order to prevent that from happening we can pull the code for toggling
> to ready out of the interrupt path and instead place it in the
> fbnic_mbx_poll_tx_ready path so that it becomes the only spot where the
> Rx/Tx can toggle to the ready state. By doing this we can prevent races
> where we disable the DMA and/or free buffers only to have an interrupt fire
> and undo what we have done.
>
> Fixes: da3cde08209e ("eth: fbnic: Add FW communication mechanism")
> Signed-off-by: Alexander Duyck <alexanderduyck@fb.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2025-05-06 18:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 15:59 [net PATCH v2 0/8] fbnic: FW IPC Mailbox fixes Alexander Duyck
2025-05-06 15:59 ` [net PATCH v2 1/8] fbnic: Fix initialization of mailbox descriptor rings Alexander Duyck
2025-05-06 18:44 ` Jacob Keller
2025-05-06 15:59 ` [net PATCH v2 2/8] fbnic: Gate AXI read/write enabling on FW mailbox Alexander Duyck
2025-05-06 18:45 ` Jacob Keller
2025-05-06 15:59 ` [net PATCH v2 3/8] fbnic: Add additional handling of IRQs Alexander Duyck
2025-05-06 18:47 ` Jacob Keller
2025-05-06 15:59 ` [net PATCH v2 4/8] fbnic: Actually flush_tx instead of stalling out Alexander Duyck
2025-05-06 18:52 ` Jacob Keller
2025-05-06 20:31 ` Alexander Duyck
2025-05-06 22:03 ` Jacob Keller
2025-05-06 16:00 ` [net PATCH v2 5/8] fbnic: Cleanup handling of completions Alexander Duyck
2025-05-06 18:53 ` Jacob Keller
2025-05-06 16:00 ` [net PATCH v2 6/8] fbnic: Improve responsiveness of fbnic_mbx_poll_tx_ready Alexander Duyck
2025-05-06 18:54 ` Jacob Keller
2025-05-06 16:00 ` [net PATCH v2 7/8] fbnic: Pull fbnic_fw_xmit_cap_msg use out of interrupt context Alexander Duyck
2025-05-06 18:56 ` Jacob Keller
2025-05-06 20:14 ` Alexander Duyck
2025-05-06 16:00 ` [net PATCH v2 8/8] fbnic: Do not allow mailbox to toggle to ready outside fbnic_mbx_poll_tx_ready Alexander Duyck
2025-05-06 18:57 ` Jacob Keller [this message]
2025-05-08 1:41 ` [net PATCH v2 0/8] fbnic: FW IPC Mailbox fixes Jakub Kicinski
2025-05-08 9:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41334bc0-4ea5-4bf6-a5c3-9726fccfd5f8@intel.com \
--to=jacob.e.keller@intel.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).