* Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27 [not found] <38386.192.168.1.2.1093850895.squirrel@www.it-technology.at> @ 2004-08-30 8:57 ` Denis Vlasenko 2004-08-30 17:33 ` Jeff Garzik 0 siblings, 1 reply; 2+ messages in thread From: Denis Vlasenko @ 2004-08-30 8:57 UTC (permalink / raw) To: Peter Holik, linux-kernel; +Cc: Jeff Garzik, Francois Romieu, netdev On Monday 30 August 2004 10:28, Peter Holik wrote: > static void set_rx_mode(struct net_device *dev) > { > spinlock_t *lp = &((struct netdev_private *)dev->priv)->lock; > unsigned long flags; > spin_lock_irqsave(lp, flags); > __set_rx_mode(dev); > - spin_unlock_irqrestore(&lp, flags); > + spin_unlock_irqrestore(lp, flags); > } Oh... it was my change which was buggy... Thanks for the fix! Jeff, 2.6 most probably has the same bug. -- vda ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PROBLEM: fix fealnx.c hangs on SMP, 2.4.27 2004-08-30 8:57 ` PROBLEM: fix fealnx.c hangs on SMP, 2.4.27 Denis Vlasenko @ 2004-08-30 17:33 ` Jeff Garzik 0 siblings, 0 replies; 2+ messages in thread From: Jeff Garzik @ 2004-08-30 17:33 UTC (permalink / raw) To: Denis Vlasenko; +Cc: Peter Holik, linux-kernel, Francois Romieu, netdev Denis Vlasenko wrote: > On Monday 30 August 2004 10:28, Peter Holik wrote: > >>static void set_rx_mode(struct net_device *dev) >>{ >> spinlock_t *lp = &((struct netdev_private *)dev->priv)->lock; >> unsigned long flags; >> spin_lock_irqsave(lp, flags); >> __set_rx_mode(dev); >>- spin_unlock_irqrestore(&lp, flags); >>+ spin_unlock_irqrestore(lp, flags); >>} > > > Oh... it was my change which was buggy... Thanks for the fix! > > Jeff, 2.6 most probably has the same bug. Upstream 2.6 already has the fix... Jeff ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-30 17:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <38386.192.168.1.2.1093850895.squirrel@www.it-technology.at>
2004-08-30 8:57 ` PROBLEM: fix fealnx.c hangs on SMP, 2.4.27 Denis Vlasenko
2004-08-30 17:33 ` Jeff Garzik
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).