From: Peter Buckingham <peter@pantasys.com>
To: davem@redhat.com
Cc: netdev@oss.sgi.com
Subject: [PATCH 2.6] ipconfig accepts any DHCPACK
Date: Tue, 07 Sep 2004 14:46:14 -0700 [thread overview]
Message-ID: <413E2C26.5040108@pantasys.com> (raw)
Hi David,
I was playing around with using ipconfig to initialise a bunch of
systems and it turns out that the ipconfig code doesn't check to see
whether the ACK is for it or another system. I've just added a simple
check to compare the hardware address of the device to the one in the
packet.
peter
Signed-off-by: Peter Buckingham <peter@pantasys.com>
--- linus-2.6/net/ipv4/ipconfig.c 2004-09-02 14:53:54.000000000 -0700
+++ local_linux/net/ipv4/ipconfig.c 2004-09-02 14:57:49.000000000 -0700
@@ -966,6 +966,12 @@ static int __init ic_bootp_recv(struct s
break;
case DHCPACK:
+ for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
+ && (i < 16); i++);
+ if (i < 16)
+ goto drop_unlock;
+
/* Yeah! */
break;
next reply other threads:[~2004-09-07 21:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 21:46 Peter Buckingham [this message]
2004-09-07 22:02 ` [PATCH 2.6] ipconfig accepts any DHCPACK David S. Miller
2004-09-07 22:45 ` Peter Buckingham
2004-09-07 22:43 ` David S. Miller
2004-09-08 0:12 ` Joe Perches
2004-09-08 0:18 ` Peter Buckingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413E2C26.5040108@pantasys.com \
--to=peter@pantasys.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).