From: Peter Buckingham <peter@pantasys.com>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH 2.6] ipconfig accepts any DHCPACK
Date: Tue, 07 Sep 2004 15:45:06 -0700 [thread overview]
Message-ID: <413E39F2.4070708@pantasys.com> (raw)
In-Reply-To: <20040907150204.119ba849.davem@redhat.com>
David S. Miller wrote:
> Just because there are 16 bytes of hw address in the bootp packet
> layout doesn't mean the device actually has that many. Please fix
> it to use dev->addr_len.
>
is this okay?
peter
Signed-off-by: Peter Buckingham <peter@pantasys.com>
--- linus-2.6/net/ipv4/ipconfig.c 2004-09-02 14:53:54.000000000 -0700
+++ local_linux/net/ipv4/ipconfig.c 2004-09-07 15:43:39.000000000 -0700
@@ -966,6 +966,11 @@ static int __init ic_bootp_recv(struct s
break;
case DHCPACK:
+ for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
+ && (i < dev->addr_len); i++);
+ if (i < dev->addr_len)
+ goto drop_unlock;
+
/* Yeah! */
break;
next prev parent reply other threads:[~2004-09-07 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-07 21:46 [PATCH 2.6] ipconfig accepts any DHCPACK Peter Buckingham
2004-09-07 22:02 ` David S. Miller
2004-09-07 22:45 ` Peter Buckingham [this message]
2004-09-07 22:43 ` David S. Miller
2004-09-08 0:12 ` Joe Perches
2004-09-08 0:18 ` Peter Buckingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413E39F2.4070708@pantasys.com \
--to=peter@pantasys.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).