From: Peter Buckingham <peter@pantasys.com>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH 2.6] IPCONFIG fix and cleanup
Date: Wed, 08 Sep 2004 17:43:18 -0700 [thread overview]
Message-ID: <413FA726.7070006@pantasys.com> (raw)
Hi David,
The previous fix to DHCPACK missed declaring an iterator variable. based
on some comments I modified the patch to look like the below. This will
fix the promisicuous DHCPACK problem.
thanks,
peter
Signed-off-by: Peter Buckingham <peter@pantasys.com>
--- linus-2.6/net/ipv4/ipconfig.c 2004-09-08 17:35:56.000000000 -0700
+++ local_linux/net/ipv4/ipconfig.c 2004-09-07 17:16:55.000000000 -0700
@@ -966,9 +966,7 @@ static int __init ic_bootp_recv(struct s
break;
case DHCPACK:
- for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
- && (i < dev->addr_len); i++);
- if (i < dev->addr_len)
+ if (memcmp(dev->dev_addr, b->hw_addr, dev->addr_len) != 0)
goto drop_unlock;
/* Yeah! */
next reply other threads:[~2004-09-09 0:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-09 0:43 Peter Buckingham [this message]
2004-09-09 0:48 ` [PATCH 2.6] IPCONFIG fix and cleanup David S. Miller
2004-09-09 0:54 ` Peter Buckingham
2004-09-09 0:58 ` David S. Miller
2004-09-09 1:01 ` Peter Buckingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=413FA726.7070006@pantasys.com \
--to=peter@pantasys.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).