* [PATCH 2.6] IPCONFIG fix and cleanup
@ 2004-09-09 0:43 Peter Buckingham
2004-09-09 0:48 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: Peter Buckingham @ 2004-09-09 0:43 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
Hi David,
The previous fix to DHCPACK missed declaring an iterator variable. based
on some comments I modified the patch to look like the below. This will
fix the promisicuous DHCPACK problem.
thanks,
peter
Signed-off-by: Peter Buckingham <peter@pantasys.com>
--- linus-2.6/net/ipv4/ipconfig.c 2004-09-08 17:35:56.000000000 -0700
+++ local_linux/net/ipv4/ipconfig.c 2004-09-07 17:16:55.000000000 -0700
@@ -966,9 +966,7 @@ static int __init ic_bootp_recv(struct s
break;
case DHCPACK:
- for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
- && (i < dev->addr_len); i++);
- if (i < dev->addr_len)
+ if (memcmp(dev->dev_addr, b->hw_addr, dev->addr_len) != 0)
goto drop_unlock;
/* Yeah! */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6] IPCONFIG fix and cleanup
2004-09-09 0:43 [PATCH 2.6] IPCONFIG fix and cleanup Peter Buckingham
@ 2004-09-09 0:48 ` David S. Miller
2004-09-09 0:54 ` Peter Buckingham
0 siblings, 1 reply; 5+ messages in thread
From: David S. Miller @ 2004-09-09 0:48 UTC (permalink / raw)
To: Peter Buckingham; +Cc: netdev
On Wed, 08 Sep 2004 17:43:18 -0700
Peter Buckingham <peter@pantasys.com> wrote:
> The previous fix to DHCPACK missed declaring an iterator variable. based
> on some comments I modified the patch to look like the below. This will
> fix the promisicuous DHCPACK problem.
Peter, how are you generating your patches? They never apply
cleanly. Maybe Mozilla is messing it up, who knows. Perhaps
try using attachments instead.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6] IPCONFIG fix and cleanup
2004-09-09 0:48 ` David S. Miller
@ 2004-09-09 0:54 ` Peter Buckingham
2004-09-09 0:58 ` David S. Miller
0 siblings, 1 reply; 5+ messages in thread
From: Peter Buckingham @ 2004-09-09 0:54 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
[-- Attachment #1: Type: text/plain, Size: 272 bytes --]
> Peter, how are you generating your patches? They never apply
> cleanly. Maybe Mozilla is messing it up, who knows. Perhaps
> try using attachments instead.
sorry, try this attachment instead. when i get sendmail configured
properly i'll use mutt instead ;-)
peter
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 460 bytes --]
--- linus-2.6/net/ipv4/ipconfig.c 2004-09-08 17:35:56.000000000 -0700
+++ local_linux/net/ipv4/ipconfig.c 2004-09-07 17:16:55.000000000 -0700
@@ -966,9 +966,7 @@ static int __init ic_bootp_recv(struct s
break;
case DHCPACK:
- for (i = 0; (dev->dev_addr[i] == b->hw_addr[i])
- && (i < dev->addr_len); i++);
- if (i < dev->addr_len)
+ if (memcmp(dev->dev_addr, b->hw_addr, dev->addr_len) != 0)
goto drop_unlock;
/* Yeah! */
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6] IPCONFIG fix and cleanup
2004-09-09 0:54 ` Peter Buckingham
@ 2004-09-09 0:58 ` David S. Miller
2004-09-09 1:01 ` Peter Buckingham
0 siblings, 1 reply; 5+ messages in thread
From: David S. Miller @ 2004-09-09 0:58 UTC (permalink / raw)
To: Peter Buckingham; +Cc: netdev
On Wed, 08 Sep 2004 17:54:27 -0700
Peter Buckingham <peter@pantasys.com> wrote:
> > Peter, how are you generating your patches? They never apply
> > cleanly. Maybe Mozilla is messing it up, who knows. Perhaps
> > try using attachments instead.
>
> sorry, try this attachment instead. when i get sendmail configured
> properly i'll use mutt instead ;-)
Applied, thanks.
BTW I put the full fix into my 2.4.x tree as well and will push
that to Marcelo when I get the chance.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2.6] IPCONFIG fix and cleanup
2004-09-09 0:58 ` David S. Miller
@ 2004-09-09 1:01 ` Peter Buckingham
0 siblings, 0 replies; 5+ messages in thread
From: Peter Buckingham @ 2004-09-09 1:01 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev
David S. Miller wrote:
> Applied, thanks.
>
> BTW I put the full fix into my 2.4.x tree as well and will push
> that to Marcelo when I get the chance.
cool, thanks.
peter
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2004-09-09 1:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-09 0:43 [PATCH 2.6] IPCONFIG fix and cleanup Peter Buckingham
2004-09-09 0:48 ` David S. Miller
2004-09-09 0:54 ` Peter Buckingham
2004-09-09 0:58 ` David S. Miller
2004-09-09 1:01 ` Peter Buckingham
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).