netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Andi Kleen <ak@suse.de>
Cc: "David S. Miller" <davem@davemloft.net>,
	hadi@cyberus.ca, herbert@gondor.apana.org.au, netdev@oss.sgi.com
Subject: Re: [PATCH] NETIF_F_LLTX for devices 2
Date: Mon, 13 Sep 2004 12:10:03 -0400	[thread overview]
Message-ID: <4145C65B.4050703@pobox.com> (raw)
In-Reply-To: <20040913065958.GC12185@wotan.suse.de>

Andi Kleen wrote:
> On Sun, Sep 12, 2004 at 12:16:05PM -0400, Jeff Garzik wrote:
> 
>>Incorrect, you are changing the callsites, which -does- affect every
>>driver.
> 
> 
> Please read the code before making such claims. 
> 
> The new return code is _only_ checked when NETIF_F_LLTX is set. 
> A driver that doesn't set this new flag won't ever recognize 
> any difference.


I read the code :)

The basic premise is that one should be _really_ conservative when 
touching the core RX and TX paths.  Regardless of how safe _you_ feel 
the code is, it is very new, under-analyzed, and untried.

The NAPI-related bug recently fixed in tg3 is an example of the 
unintended consequences of using this new feature.

	Jeff

  reply	other threads:[~2004-09-13 16:10 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-07 12:05 [PATCH] NETIF_F_LLTX for devices 2 Andi Kleen
2004-09-07 21:39 ` David S. Miller
2004-09-07 21:53 ` jamal
2004-09-08  6:51   ` Andi Kleen
2004-09-08  7:07     ` Herbert Xu
2004-09-08  7:24       ` Andi Kleen
2004-09-08  7:47         ` jamal
2004-09-08 20:47           ` David S. Miller
2004-09-10 13:33             ` jamal
2004-09-10 23:02               ` David S. Miller
2004-09-11 14:21               ` Andi Kleen
2004-09-11 20:15                 ` jamal
2004-09-12  0:45                   ` David S. Miller
2004-09-12  9:57                     ` Jeff Garzik
2004-09-12 10:01                     ` Jeff Garzik
2004-09-12 10:25                       ` Andi Kleen
2004-09-12 11:03                         ` Francois Romieu
2004-09-13  0:13                           ` David S. Miller
2004-09-12 16:16                         ` Jeff Garzik
2004-09-12 17:34                           ` jamal
2004-09-13  0:06                             ` Jeff Garzik
2004-09-13  0:10                             ` David S. Miller
2004-09-13  2:52                             ` Andrew Grover
2004-09-13  6:59                           ` Andi Kleen
2004-09-13 16:10                             ` Jeff Garzik [this message]
2004-09-13  0:12                         ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4145C65B.4050703@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=ak@suse.de \
    --cc=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).