From: Jeff Garzik <jgarzik@pobox.com>
To: Andi Kleen <ak@muc.de>
Cc: davem@redhat.com, netdev@oss.sgi.com, arjanv@redhat.com
Subject: Re: [PATCH] Fix locking bug in lltx path
Date: Mon, 13 Sep 2004 15:39:53 -0400 [thread overview]
Message-ID: <4145F789.7010502@pobox.com> (raw)
In-Reply-To: <m3vfei9gzv.fsf@averell.firstfloor.org>
Andi Kleen wrote:
> Thanks to Arjan's spinlock debug kernel for finding it.
>
> This fixes a silly missing spin lock in the relock path. For some
> reason it seems to still work when you don't have spinlock debugging
> enabled.
>
> Please apply.
>
> -Andi
>
> --------------------------------------------------------------------
>
> Fix missing spin lock in lltx path.
>
> Thanks to Arjan's spinlock debug kernel for finding it.
>
> Signed-off-by: Andi Kleen <ak@muc.de>
>
> diff -u linux-2.6.9rc1-bk19/net/sched/sch_generic.c-X linux-2.6.9rc1-bk19/net/sched/sch_generic.c
> --- linux-2.6.9rc1-bk19/net/sched/sch_generic.c-X 2004-09-13 08:51:46.000000000 +0200
> +++ linux-2.6.9rc1-bk19/net/sched/sch_generic.c 2004-09-13 19:22:50.000000000 +0200
> @@ -153,8 +153,10 @@
> spin_lock(&dev->queue_lock);
> return -1;
> }
> - if (ret == -1 && nolock)
> + if (ret == -1 && nolock) {
> + spin_lock(&dev->queue_lock);
> goto collision;
> + }
please use the fancy new constants :)
Jeff
next prev parent reply other threads:[~2004-09-13 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-13 18:11 [PATCH] Fix locking bug in lltx path Andi Kleen
2004-09-13 19:18 ` David S. Miller
2004-09-13 19:26 ` Andi Kleen
2004-09-13 20:02 ` David S. Miller
2004-09-13 19:39 ` Jeff Garzik [this message]
2004-09-14 1:43 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4145F789.7010502@pobox.com \
--to=jgarzik@pobox.com \
--cc=ak@muc.de \
--cc=arjanv@redhat.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).