From: Patrick McHardy <kaber@trash.net>
To: Thomas Graf <tgraf@suug.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
netdev@oss.sgi.com
Subject: Re: [PATCH 2.6 NET] Fixes slab corruption in cbq_destroy
Date: Thu, 16 Sep 2004 16:58:26 +0200 [thread overview]
Message-ID: <4149AA12.10306@trash.net> (raw)
In-Reply-To: <20040916140943.GC27293@postel.suug.ch>
Thomas Graf wrote:
>* Patrick McHardy <4149998C.6060501@trash.net> 2004-09-16 15:47
>
>
>>I don't see how there can be slab corruption. qdisc_put_rtab only
>>calls kfree if the table is found in qdisc_rtab_list, which only
>>happens once. But the patch is still fine as cleanup :)
>>
>>
>
>On second call to qdisc_put_rtab with tab pointing to an already
>freed qdisc_rate_table:
>
>sch_api.c:271: if (!tab || --tab->refcnt)
>
>
You're right, no double free but accessing and modifying of freed memory.
Regards
Patrick
next prev parent reply other threads:[~2004-09-16 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-16 13:28 [PATCH 2.6 NET] Fixes slab corruption in cbq_destroy Thomas Graf
2004-09-16 13:47 ` Patrick McHardy
2004-09-16 14:09 ` Thomas Graf
2004-09-16 14:58 ` Patrick McHardy [this message]
2004-09-16 20:33 ` Thomas Graf
2004-09-16 20:29 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4149AA12.10306@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@oss.sgi.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).