From: Jeff Garzik <jgarzik@pobox.com>
To: Ganesh Venkatesan <ganesh.venkatesan@intel.com>
Cc: netdev@oss.sgi.com
Subject: Re: [patch 8/8 2.5] e1000 - White space changes, driver version number update and others
Date: Fri, 17 Sep 2004 11:00:46 -0400 [thread overview]
Message-ID: <414AFC1E.5010204@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0409170239280.15233-100000@isotope.jf.intel.com>
> @@ -386,10 +386,10 @@ e1000_probe(struct pci_dev *pdev,
> if((err = pci_enable_device(pdev)))
> return err;
>
> - if(!(err = pci_set_dma_mask(pdev, DMA_64BIT_MASK))) {
> + if(!(err = pci_set_dma_mask(pdev, PCI_DMA_64BIT))) {
> pci_using_dac = 1;
> } else {
> - if((err = pci_set_dma_mask(pdev, DMA_32BIT_MASK))) {
> + if((err = pci_set_dma_mask(pdev, PCI_DMA_32BIT))) {
> E1000_ERR("No usable DMA configuration, aborting\n");
> return err;
> }
>
>
>
>
Applied patches 1-2 and patches 4-7 to 2.6.x.
Patch #8 (quoted above) is rejected because DMA_..BIT_MASK is the
preferred method for 2.6.x kernels. The above patch is a regression.
Patch #3 is rejected because of an email problem:
> bk import -tpatch -CR -ye1000 - Fix MODULE_PARM, module_param and /tmp/patch25004 .
> patch: **** malformed patch at line 62: }
prev parent reply other threads:[~2004-09-17 15:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-17 9:58 [patch 8/8 2.5] e1000 - White space changes, driver version number update and others Ganesh Venkatesan
2004-09-17 15:00 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=414AFC1E.5010204@pobox.com \
--to=jgarzik@pobox.com \
--cc=ganesh.venkatesan@intel.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).