From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH v2] tcp: identify cryptic messages as TCP seq # bugs Date: Tue, 17 Jul 2018 22:03:32 -0700 Message-ID: <41567158-1d2c-7621-7292-044afa9b76db@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: =?UTF-8?B?56mN5Li55bC8IERhbiBKYWNvYnNvbg==?= To: Randy Dunlap , "netdev@vger.kernel.org" , Eric Dumazet , David Miller Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:37832 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725979AbeGRFje (ORCPT ); Wed, 18 Jul 2018 01:39:34 -0400 Received: by mail-pf0-f196.google.com with SMTP id a26-v6so1604596pfo.4 for ; Tue, 17 Jul 2018 22:03:35 -0700 (PDT) In-Reply-To: Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 07/17/2018 06:27 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Attempt to make cryptic TCP seq number error messages clearer by > (1) identifying the source of the message as "TCP", (2) identifying the > errors as "seq # bug", and (3) grouping the field identifiers and values > by separating them with commas. > > E.g., the following message is changed from: > > recvmsg bug 2: copied 73BCB6CD seq 70F17CBE rcvnxt 73BCB9AA fl 0 > WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:1881 tcp_recvmsg+0x649/0xb90 > > to: > > TCP recvmsg seq # bug 2: copied 73BCB6CD, seq 70F17CBE, rcvnxt 73BCB9AA, fl 0 > WARNING: CPU: 2 PID: 1501 at /linux/net/ipv4/tcp.c:2011 tcp_recvmsg+0x694/0xba0 > > Suggested-by: 積丹尼 Dan Jacobson > Signed-off-by: Randy Dunlap Thanks Randy Signed-off-by: Eric Dumazet