netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nivedita Singhvi <niv@us.ibm.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@oss.sgi.com
Subject: Re: [TCP] Fixed mss in tcp_init_cwnd
Date: Mon, 27 Sep 2004 08:43:51 -0700	[thread overview]
Message-ID: <41583537.2090906@us.ibm.com> (raw)
In-Reply-To: <20040927080828.GA12056@gondor.apana.org.au>

Herbert Xu wrote:

> ===== net/ipv4/tcp_input.c 1.73 vs edited =====
> --- 1.73/net/ipv4/tcp_input.c	2004-09-13 10:30:58 +10:00
> +++ edited/net/ipv4/tcp_input.c	2004-09-27 17:00:32 +10:00
> @@ -799,10 +799,10 @@
>  	__u32 cwnd = (dst ? dst_metric(dst, RTAX_INITCWND) : 0);
>  
>  	if (!cwnd) {
> -		if (tp->mss_cache > 1460)
> +		if (tp->mss_cache_std > 1460)
>  			cwnd = 2;
>  		else
> -			cwnd = (tp->mss_cache > 1095) ? 3 : 4;
> +			cwnd = (tp->mss_cache_std > 1095) ? 3 : 4;
>  	}
>  	return min_t(__u32, cwnd, tp->snd_cwnd_clamp);
>  }

Helps to send after finishing commenting..

I fixed this locally but was still seeing poor throughput,
though it does correct how many we initially/on restart send out.
Thought this was fixed in the bk tree?

thanks,
Nivedita

  parent reply	other threads:[~2004-09-27 15:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-09-27  8:08 [TCP] Fixed mss in tcp_init_cwnd Herbert Xu
2004-09-27 15:36 ` Nivedita Singhvi
2004-09-27 15:43 ` Nivedita Singhvi [this message]
2004-09-27 19:00 ` David S. Miller
2004-09-27 22:02   ` Herbert Xu
2004-09-27 23:04     ` David S. Miller
2004-09-27 23:09       ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41583537.2090906@us.ibm.com \
    --to=niv@us.ibm.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).