From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Joe Perches <joe@perches.com>
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH] introduce eth_hdr(skb)
Date: Sat, 02 Oct 2004 14:22:41 -0300 [thread overview]
Message-ID: <415EE3E1.7020806@conectiva.com.br> (raw)
In-Reply-To: <Pine.LNX.4.10.10410021058520.7525-100000@netwinder.perches.com>
Joe Perches wrote:
>
> - } else if (skb->mac.ethernet->h_proto == __constant_htons(ETH_P_ARP)) {
> + } else if (eth_hdr(skb)->h_proto == htons(ETH_P_ARP)) {
>
> I believe the __constant_htons conversions to htons are incorrect.
No they aren't, look at the generated code for both variations when
receiving a constant :-)
- Arnaldo
next prev parent reply other threads:[~2004-10-02 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-02 16:53 [PATCH] introduce eth_hdr(skb) Arnaldo Carvalho de Melo
2004-10-02 18:01 ` Joe Perches
2004-10-02 17:22 ` Arnaldo Carvalho de Melo [this message]
2004-10-02 18:40 ` Joe Perches
2004-10-02 18:10 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=415EE3E1.7020806@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=davem@redhat.com \
--cc=joe@perches.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).