From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH 2.6 2/7]: Remove useless variable in tc_ctl_tfilter
Date: Sun, 03 Oct 2004 23:12:53 +0200 [thread overview]
Message-ID: <41606B55.8010105@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 44 bytes --]
Remove useless variable that confused me.
[-- Attachment #2: 02.diff --]
[-- Type: text/x-patch, Size: 1602 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/10/03 20:29:51+02:00 kaber@coreworks.de
# [NET_SCHED]: Remove useless variable in tc_ctl_tfilter
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/sched/cls_api.c
# 2004/10/03 20:29:23+02:00 kaber@coreworks.de +4 -4
# [NET_SCHED]: Remove useless variable in tc_ctl_tfilter
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
diff -Nru a/net/sched/cls_api.c b/net/sched/cls_api.c
--- a/net/sched/cls_api.c 2004-10-03 22:18:34 +02:00
+++ b/net/sched/cls_api.c 2004-10-03 22:18:34 +02:00
@@ -139,7 +139,7 @@
struct tcf_proto_ops *tp_ops;
struct Qdisc_class_ops *cops;
unsigned long cl = 0;
- unsigned long fh, fh_s;
+ unsigned long fh;
int err;
if (prio == 0) {
@@ -249,7 +249,7 @@
} else if (tca[TCA_KIND-1] && rtattr_strcmp(tca[TCA_KIND-1], tp->ops->kind))
goto errout;
- fh_s = fh = tp->ops->get(tp, t->tcm_handle);
+ fh = tp->ops->get(tp, t->tcm_handle);
if (fh == 0) {
if (n->nlmsg_type == RTM_DELTFILTER && t->tcm_handle == 0) {
@@ -257,7 +257,7 @@
*back = tp->next;
qdisc_unlock_tree(dev);
- tfilter_notify(skb, n, tp, fh_s, RTM_DELTFILTER);
+ tfilter_notify(skb, n, tp, fh, RTM_DELTFILTER);
tcf_destroy(tp);
err = 0;
goto errout;
@@ -276,7 +276,7 @@
case RTM_DELTFILTER:
err = tp->ops->delete(tp, fh);
if (err == 0)
- tfilter_notify(skb, n, tp, fh_s, RTM_DELTFILTER);
+ tfilter_notify(skb, n, tp, fh, RTM_DELTFILTER);
goto errout;
case RTM_GETTFILTER:
err = tfilter_notify(skb, n, tp, fh, RTM_NEWTFILTER);
reply other threads:[~2004-10-03 21:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41606B55.8010105@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).