From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: [PATCH 2.6 7/7]: Missing rtnl_unlock in register_vlan_device error path
Date: Sun, 03 Oct 2004 23:13:44 +0200 [thread overview]
Message-ID: <41606B88.1000003@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 67 bytes --]
rtnl_unlock is not called in the out_free_unregister error path.
[-- Attachment #2: 07.diff --]
[-- Type: text/x-patch, Size: 754 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/10/03 20:44:53+02:00 kaber@coreworks.de
# [VLAN]: Missing rtnl_unlock in register_vlan_device error path
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/8021q/vlan.c
# 2004/10/03 20:44:27+02:00 kaber@coreworks.de +1 -1
# [VLAN]: Missing rtnl_unlock in register_vlan_device error path
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
diff -Nru a/net/8021q/vlan.c b/net/8021q/vlan.c
--- a/net/8021q/vlan.c 2004-10-03 22:21:30 +02:00
+++ b/net/8021q/vlan.c 2004-10-03 22:21:30 +02:00
@@ -537,7 +537,7 @@
out_free_unregister:
unregister_netdev(new_dev);
- goto out_put_dev;
+ goto out_unlock;
out_free_newdev:
free_netdev(new_dev);
reply other threads:[~2004-10-03 21:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41606B88.1000003@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).