From: Manfred Spraul <manfred@colorfullife.com>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com
Subject: Re: [PATCH] fix secure tcp sequence number generation
Date: Mon, 04 Oct 2004 06:06:18 +0200 [thread overview]
Message-ID: <4160CC3A.4050606@colorfullife.com> (raw)
In-Reply-To: <20041003150052.4dba0c60.davem@redhat.com>
David S. Miller wrote:
>On Sat, 02 Oct 2004 20:10:22 +0200
>Manfred Spraul <manfred@colorfullife.com> wrote:
>
>
>
>>Ted's recent random.c update broke the periodic rekeying:
>>schedule_work() doesn't provide synchronization. Additionally the first
>>syn values after boot are generated with secret 0 - not good.
>>
>>
>
>Are you referring to his changes done back in August or some
>other change? August is the last time I see that Ted made
>a change to drivers/char/random.c
>
>
The change to revision 1.49 of random.c, with the comment
"dev/random: Fix latency in rekeying sequence number"
http://linux.bkbits.net:8080/linux-2.5/diffs/drivers/char/random.c@1.49
There are two problems with that patch:
- The first call of check_and_rekey must be synchroneous, otherwise the
secret stays 0 for the first ISN values after boot.
- schedule_work() doesn't provide synchronization, thus
rekey_seq_generator could end up running twice.
I tried to fix it and then I noticed that it's possible to simplify the
code a lot.
--
Manfred
next prev parent reply other threads:[~2004-10-04 4:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-02 18:10 [PATCH] fix secure tcp sequence number generation Manfred Spraul
2004-10-03 22:00 ` David S. Miller
2004-10-04 4:06 ` Manfred Spraul [this message]
2004-10-05 20:27 ` David S. Miller
2004-10-05 20:41 ` Manfred Spraul
2004-10-05 21:31 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4160CC3A.4050606@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).