From: rdunlap@xenotime.net
To: "Peter P Waskiewicz Jr" <peter.p.waskiewicz.jr@intel.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, linux-kernel@vger.kernel.org,
andi@firstfloor.org, netdev@vger.kernel.org,
peter.p.waskiewicz.jr@intel.com
Subject: Re: [PATCH] [arch-x86] Allow SRAT integrity check to be skipped
Date: Wed, 1 Sep 2010 15:04:24 -0700 (PDT) [thread overview]
Message-ID: <41621.148.87.67.139.1283378664.squirrel@www.xenotime.net> (raw)
In-Reply-To: <20100901213318.19353.54619.stgit@localhost.localdomain>
On Wed, September 1, 2010 2:33 pm, Peter P Waskiewicz Jr wrote:
> Documentation/x86/x86_64/boot-options.txt | 4 ++++
> arch/x86/mm/srat_64.c | 20 +++++++++++++++++--- 2
> files changed, 21 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/mm/srat_64.c b/arch/x86/mm/srat_64.c index
> f9897f7..8719472 100644 --- a/arch/x86/mm/srat_64.c
> +++ b/arch/x86/mm/srat_64.c
> @@ -351,6 +351,15 @@ int __init acpi_get_nodes(struct bootnode *physnodes)
> return ret; }
>
>
> +int srat_bypass_bios = 0;
static int srat_bypass_bios;
Don't need to init to 0.
> +
> +static int __init srat_bypass_bios_setup(char *str)
> +{
> + srat_bypass_bios = 1;
> + return 0;
> +}
> +early_param("sratbypassbios", srat_bypass_bios_setup);
> +
> /* Use the information discovered above to actually set up the nodes. */
> int __init acpi_scan_nodes(unsigned long start, unsigned long end) {
> @@ -425,9 +434,14 @@ int __init acpi_scan_nodes(unsigned long start,
> unsigned long end) nodes[i].end >> PAGE_SHIFT); /* for out of order entries
> in SRAT */ sort_node_map(); - if (!nodes_cover_memory(nodes)) {
> - bad_srat();
> - return -1;
> + if (!srat_bypass_bios) {
> + if (!nodes_cover_memory(nodes)) {
> + bad_srat();
> + return -1;
> + }
> + } else {
> + printk(KERN_INFO
> + "SRAT: Bypassing NUMA sanity check...bad BIOS...\n");
> }
next prev parent reply other threads:[~2010-09-01 22:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-01 21:33 [PATCH] [arch-x86] Allow SRAT integrity check to be skipped Peter P Waskiewicz Jr
2010-09-01 21:33 ` Andi Kleen
2010-09-01 22:04 ` rdunlap [this message]
2010-09-01 22:11 ` Peter P Waskiewicz Jr
2010-09-08 19:09 ` H. Peter Anvin
2010-09-03 10:04 ` Andi Kleen
2010-09-02 6:57 ` Ingo Molnar
2010-09-02 10:03 ` Andi Kleen
2010-09-03 6:39 ` Ingo Molnar
2010-09-07 19:38 ` Peter P Waskiewicz Jr
2010-09-07 19:56 ` Ingo Molnar
2010-09-07 20:03 ` H. Peter Anvin
2010-09-07 20:16 ` Peter P Waskiewicz Jr
2010-09-07 20:48 ` H. Peter Anvin
2010-09-08 6:55 ` Andi Kleen
2010-09-08 18:03 ` H. Peter Anvin
2010-09-08 18:51 ` Peter P Waskiewicz Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41621.148.87.67.139.1283378664.squirrel@www.xenotime.net \
--to=rdunlap@xenotime.net \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).