Re: [PATCH 2/2] [SKBUFF] introduce tr_hdr(skb)

[Arnaldo Carvalho de Melo <acme@conectiva.com.br>]

Arnaldo Carvalho de Melo wrote:
> 
> 
> Thomas Graf wrote:
> 
>> * Arnaldo Carvalho de Melo <41643C40.8070605@conectiva.com.br> 
>> 2004-10-06 15:41
>>
>>> -        trh = (struct trh_hdr *)skb_push(skb, sizeof(*trh));
>>> +        skb->mac.raw = skb_push(skb, sizeof(*trh));
>>> +        trh = tr_hdr(skb);
>>>         trh->ac = AC;
>>>         trh->fc = LLC_FRAME;
>>>         if (sa)
>>> @@ -51,7 +52,6 @@
>>>             memcpy(trh->daddr, da, dev->addr_len);
>>>             tr_source_route(skb, trh, dev);
>>>         }
>>> -        skb->mac.raw = skb->data;
>>
>>
>>
>> Are you sure the bevhaviour is the same? There is an skb_pull
>> in tr_source_route so skb->data gets modified.
>>
> 
> 
> Thanks for reviewing, checking...
> 
> 

You're right, if tr_source_route is called, skb->mac.raw has to be set
to skb->data, to maintain the old behaviour, if it is right? Oh well,
as I said there aren't many people using Token Ring, let alone LLC over
token ring, I'll be posting a patch in some minutes.

- Arnaldo