From: Ben Greear <greearb@candelatech.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: Robert.Olsson@data.slu.se, netdev@oss.sgi.com
Subject: Re: 2.6.7 tulip performance (with NAPI)
Date: Thu, 07 Oct 2004 11:09:14 -0700 [thread overview]
Message-ID: <4165864A.2010805@candelatech.com> (raw)
In-Reply-To: <20041006180826.4a092c71.davem@davemloft.net>
David S. Miller wrote:
> On Wed, 06 Oct 2004 17:56:05 -0700
> Ben Greear <greearb@candelatech.com> wrote:
>
>
>>It may be that other programs would like to use the notify_queue_woken hook, so
>>if this were ever to hit the kernel proper, might want to make this a linked list
>>of callbacks instead of a simple pointer.
>
>
> This sort of suggests that pktgen may be better implemented
> via a kind of special queueing discipline. Just an idea.
Care to elaborate? From what I can tell, the default code wakes
up the soft-irq thread when the NIC queue has available space again. I
suppose that that will in turn wake up the sockets waiting to write
to that NIC again. To me, it seemed more efficient, if perhaps less
flexible, to have the queue-has-space callback to directly wake the
writer thread(s).
I do wonder how this would work with virtual interfaces, such as 802.1Q
vlans, which have no queues. I could make the pktgen hook aware of the
VLAN <-> ethX relationship, or could have the callback generate callbacks for
all associated VLANs, but neither seems very elegant or scalable.
How does the existing (non pktgen) architecture work for VLAN devices
and stopping/starting the queues in the underlying devices?
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2004-10-07 18:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-05 23:42 2.6.7 tulip performance (with NAPI) Ben Greear
2004-10-06 19:21 ` Robert Olsson
2004-10-06 21:37 ` Ben Greear
2004-10-07 0:56 ` Ben Greear
2004-10-07 1:08 ` David S. Miller
2004-10-07 18:09 ` Ben Greear [this message]
2004-10-11 4:07 ` David S. Miller
2004-10-07 21:11 ` Robert Olsson
2004-10-07 21:47 ` Ben Greear
2004-10-07 22:13 ` Robert Olsson
2004-10-07 23:44 ` Lennert Buytenhek
2004-10-08 9:25 ` P
2004-10-08 9:28 ` Lennert Buytenhek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4165864A.2010805@candelatech.com \
--to=greearb@candelatech.com \
--cc=Robert.Olsson@data.slu.se \
--cc=davem@davemloft.net \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).