netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@oss.sgi.com
Subject: [PATCH] pktgen: sprintf arg type warning
Date: Sat, 09 Oct 2004 15:07:03 -0700	[thread overview]
Message-ID: <41686107.7030508@osdl.org> (raw)
In-Reply-To: <20041008221934.42a6bc7a.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

> This won't fix the problem on sparc64 where u64 is an "unsigned long"
> So, just cast the thing to the type gcc wants "unsigned long long"

Yep, I should have known that.  New patch attached.

(Note:  testing new mail client; hopefully it's not munged.)

-- 
~Randy

[-- Attachment #2: pktgen_type.patch --]
[-- Type: text/x-patch, Size: 790 bytes --]


Fix printk arg format warning:
net/core/pktgen.c:607: warning: long long unsigned int format, long unsigned int arg (arg 4)

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat:=
 net/core/pktgen.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -Naurp ./net/core/pktgen.c~pktgen_type ./net/core/pktgen.c
--- ./net/core/pktgen.c~pktgen_type	2004-10-06 15:04:06.260548504 -0700
+++ ./net/core/pktgen.c	2004-10-09 15:04:10.907452600 -0700
@@ -603,7 +603,7 @@ static void show_results(struct pktgen_i
 	do_div(idle, cpu_speed);
 
 	p += sprintf(p, "OK: %llu(c%llu+d%lu) usec, %llu (%dbyte,%dfrags)\n",
-		     total, total - idle, idle,
+		     total, (unsigned long long)(total - idle), idle,
 		     info->sofar, size, nr_frags);
 
 	pps = info->sofar * USEC_PER_SEC;

      parent reply	other threads:[~2004-10-09 22:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-09  3:30 [PATCH] pktgen: sprintf arg type warning Randy.Dunlap
2004-10-09  5:19 ` David S. Miller
2004-10-09 17:30   ` Sam Leffler
2004-10-09 17:36     ` Andi Kleen
2004-10-09 17:49       ` Sam Leffler
2004-10-09 22:07   ` Randy.Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41686107.7030508@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=davem@davemloft.net \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).