netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: netdev <netdev@oss.sgi.com>, jgarzik <jgarzik@pobox.com>,
	tsbogend@alpha.franken.de, brazilnut@us.ibm.com
Subject: [PATCH] pcnet32: use unsigned 1-bit fields
Date: Sun, 10 Oct 2004 15:44:46 -0700	[thread overview]
Message-ID: <4169BB5E.1070409@osdl.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 84 bytes --]


1-bit fields should be unsigned.  Keeps sparse happy,
keeps gcc straight.

~Randy


[-- Attachment #2: pcnet32_bits.patch --]
[-- Type: text/x-patch, Size: 1003 bytes --]


Fix sparse warning and tell gcc that 1-bit fields are unsigned.
drivers/net/pcnet32.c:362:21: warning: dubious one-bit signed bitfield

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat:=
 drivers/net/pcnet32.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff -Naurp ./drivers/net/pcnet32.c~pcnet_bits ./drivers/net/pcnet32.c
--- ./drivers/net/pcnet32.c~pcnet_bits	2004-08-13 22:36:33.000000000 -0700
+++ ./drivers/net/pcnet32.c	2004-10-10 15:23:07.964797120 -0700
@@ -359,9 +359,9 @@ struct pcnet32_private {
     struct net_device_stats stats;
     char		tx_full;
     int			options;
-    int	shared_irq:1,			/* shared irq possible */
-	dxsuflo:1,			/* disable transmit stop on uflo */
-	mii:1;				/* mii port available */
+    unsigned int	shared_irq:1,	/* shared irq possible */
+			dxsuflo:1,	/* disable transmit stop on uflo */
+			mii:1;		/* mii port available */
     struct net_device	*next;
     struct mii_if_info	mii_if;
     struct timer_list	watchdog_timer;


             reply	other threads:[~2004-10-10 22:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-10 22:44 Randy.Dunlap [this message]
2004-10-15 19:26 ` [PATCH] pcnet32: use unsigned 1-bit fields Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4169BB5E.1070409@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=brazilnut@us.ibm.com \
    --cc=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).