From: Jan Dittmer <j.dittmer@portrix.net>
To: Cal Peake <cp@absolutedigital.net>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
NetDev Mailing List <netdev@oss.sgi.com>,
proski@gnu.org, hermes@gibson.dropbear.id.au
Subject: Re: [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h
Date: Mon, 11 Oct 2004 13:54:44 +0200 [thread overview]
Message-ID: <416A7484.1030703@portrix.net> (raw)
In-Reply-To: <Pine.LNX.4.61.0410110702590.7899@linaeum.absolutedigital.net>
Cal Peake wrote:
> Hi,
>
> This patch fixes several dozen warnings spit out when compiling the hermes
> wireless driver.
>
> In file included from drivers/net/wireless/orinoco.c:448:
> drivers/net/wireless/hermes.h: In function `hermes_present':
> drivers/net/wireless/hermes.h:398: warning: passing arg 1 of `readw' makes pointer from integer without a cast
> drivers/net/wireless/hermes.h: In function `hermes_set_irqmask':
> drivers/net/wireless/hermes.h:404: warning: passing arg 2 of `writew' makes pointer from integer without a cast
> ...
> inw((hw)->iobase + ( (off) << (hw)->reg_spacing )) : \
> - readw((hw)->iobase + ( (off) << (hw)->reg_spacing )))
> + readw((void __iomem *)(hw)->iobase + ( (off) << (hw)->reg_spacing )))
> #define hermes_write_reg(hw, off, val) do { \
Isn't the correct fix to declare iobase as (void __iomem *) ?
Thanks,
Jank
next prev parent reply other threads:[~2004-10-11 11:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 11:34 [PATCH] Fix readw/writew warnings in drivers/net/wireless/hermes.h Cal Peake
2004-10-11 11:54 ` Jan Dittmer [this message]
2004-10-11 12:04 ` Ricky lloyd
2004-10-11 12:31 ` David Gibson
2004-10-11 12:42 ` Cal Peake
2004-10-11 13:18 ` Borislav Petkov
2004-10-11 13:33 ` viro
2004-10-11 12:23 ` Cal Peake
2004-10-11 12:29 ` Jan Dittmer
2004-10-11 12:32 ` David Gibson
2004-10-11 12:39 ` Jan Dittmer
2004-10-11 12:49 ` Ben Dooks
2004-10-11 13:16 ` viro
2004-10-11 14:16 ` Cal Peake
2004-10-11 13:12 ` Pavel Roskin
2004-10-11 14:04 ` viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416A7484.1030703@portrix.net \
--to=j.dittmer@portrix.net \
--cc=cp@absolutedigital.net \
--cc=hermes@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).