From: Con Kolivas <kernel@kolivas.org>
To: Matt Mackall <mpm@selenic.com>
Cc: netdev@oss.sgi.com,
linux kernel mailing list <linux-kernel@vger.kernel.org>,
davem@redhat.com
Subject: Re: [PATCH] netconsole support for b44
Date: Wed, 13 Oct 2004 07:48:18 +1000 [thread overview]
Message-ID: <416C5122.9040001@kolivas.org> (raw)
In-Reply-To: <20041012180949.GW5414@waste.org>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
Matt Mackall wrote:
> On Tue, Oct 12, 2004 at 09:39:23PM +1000, Con Kolivas wrote:
>
>>This patch adds poll support to the b44 driver to allow netconsole
>>support. Style lifted straight from 8139too.c
>>
>>here is the dmesg output with it in place:
>>
>>netconsole: device eth0 not up yet, forcing it
>>netconsole: carrier detect appears flaky, waiting 10 seconds
>>b44: eth0: Link is down.
>>b44: eth0: Link is up at 100 Mbps, full duplex.
>>b44: eth0: Flow control is on for TX and on for RX.
>>netconsole: network logging started
>>
>>output confirmed by netcat on other system.
>>
>>Signed-off-by: Con Kolivas <kernel@kolivas.org>
>
>
> + disable_irq(dev->irq);
> + b44_interrupt (dev->irq, dev, NULL);
> + enable_irq(dev->irq);
>
> Aside from this bizarre whitespace convention and neglecting to cc:
> me, looks good.
>
sorry,sorry,thanks.
Can you explain where I went wrong in the whitespace so I don't make the
same mistake again? It looked pretty standard to me.
Should I nudge akpm with this or will it go via another route?
Cheers,
Con
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 256 bytes --]
next prev parent reply other threads:[~2004-10-12 21:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-12 11:39 [PATCH] netconsole support for b44 Con Kolivas
2004-10-12 18:09 ` Matt Mackall
2004-10-12 21:48 ` Con Kolivas [this message]
2004-10-12 21:57 ` Matt Mackall
2004-10-12 23:26 ` [PATCH]b44poll - whitespace Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416C5122.9040001@kolivas.org \
--to=kernel@kolivas.org \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).