netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: "'netdev@oss.sgi.com'" <netdev@oss.sgi.com>
Subject: return values for hard_start_xmit and dev_queue_xmit
Date: Wed, 13 Oct 2004 11:34:14 -0700	[thread overview]
Message-ID: <416D7526.8050206@candelatech.com> (raw)

While trying to get pktgen to effectively use VLANs to send traffic,
I noticed that the vlan code always returns 0 from it's hard_start_xmit
method.  Since it calls dev_queue_xmit inside that method, I tried
returning the value that dev_queue_xmit returns.  It seems that the
return values have different meanings because this causes crashes due
to freeing skbs when I shouldn't be...

The dev_queue_xmit method is fairly well documented in dev.c, but
there are zero comments in the netdevice.h file to explain what the
acceptable return values for hard_start_xmit are.

Does anyone know if there is a definative guide to the return values
for hard_start_xmit?

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com

             reply	other threads:[~2004-10-13 18:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-13 18:34 Ben Greear [this message]
2004-10-13 18:53 ` return values for hard_start_xmit and dev_queue_xmit Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=416D7526.8050206@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).