From: Jeff Garzik <jgarzik@pobox.com>
To: ravinandan.arakali@s2io.com
Cc: "'Francois Romieu'" <romieu@fr.zoreil.com>,
netdev@oss.sgi.com, leonid.grossman@s2io.com,
raghavendra.koushik@s2io.com, rapuru.sriram@s2io.com
Subject: Re: [PATCH 2.6.9-rc2 7/8] S2io: NAPI fix
Date: Thu, 14 Oct 2004 11:00:27 -0400 [thread overview]
Message-ID: <416E948B.5050701@pobox.com> (raw)
In-Reply-To: <005601c4b18b$691ac8b0$6c10100a@S2IOtech.com>
Comments on patch #7:
1) Can you prove that put_lock is really necessary, and not covered by
other methods of synchronization? Typically the preferred model is that
your RX process requires _no_ spinlocks, and instead you use the net
stack API to ensure when your RX process is, and is not, running.
otherwise, no objections to this patch
next prev parent reply other threads:[~2004-10-14 15:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 1:16 [PATCH 2.6.9-rc2 7/8] S2io: NAPI fix Ravinandan Arakali
2004-10-14 15:00 ` Jeff Garzik [this message]
2004-10-14 16:44 ` Raghavendra Koushik
2004-10-15 18:53 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416E948B.5050701@pobox.com \
--to=jgarzik@pobox.com \
--cc=leonid.grossman@s2io.com \
--cc=netdev@oss.sgi.com \
--cc=raghavendra.koushik@s2io.com \
--cc=rapuru.sriram@s2io.com \
--cc=ravinandan.arakali@s2io.com \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).