From: Jeff Garzik <jgarzik@pobox.com>
To: Matt Mackall <mpm@selenic.com>
Cc: Petr Konecny <pekon@fi.muni.cz>, netdev@oss.sgi.com
Subject: Re: PATCH: netpoll with xircom_cb
Date: Thu, 14 Oct 2004 23:25:33 -0400 [thread overview]
Message-ID: <416F432D.4050706@pobox.com> (raw)
In-Reply-To: <20041014205440.GY5414@waste.org>
Matt Mackall wrote:
> On Thu, Oct 14, 2004 at 04:41:10AM +0200, Petr Konecny wrote:
>
>>Hi,
>>
>>I have a headless computer with xircom pcmcia card and needed netconsole
>>on it. After looking around in other drivers I concocted this patch. It
>>survived light testing. I have no documentation for the hw, so it maybe
>>totally bogus. What do you think ?
>
>
> Looks good to me.
>
> In general, this generic approach is fine. We can sometimes avoid the
> heavyweight IRQ manipulation by using internal driver locking, but
> this is generally not a performance-critical path.
>
> Jeff, did you take this one?
yes
next prev parent reply other threads:[~2004-10-15 3:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 2:41 PATCH: netpoll with xircom_cb Petr Konecny
2004-10-14 20:54 ` Matt Mackall
2004-10-15 3:25 ` Jeff Garzik [this message]
[not found] <qwwd5zmrrpt.fsf@decibel.fi.muni.cz>
[not found] ` <20041014124140.GI2646@devserv.devel.redhat.com>
2004-10-14 14:40 ` Petr Konecny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416F432D.4050706@pobox.com \
--to=jgarzik@pobox.com \
--cc=mpm@selenic.com \
--cc=netdev@oss.sgi.com \
--cc=pekon@fi.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).