netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Manfred Spraul <manfred@colorfullife.com>
Cc: marcelo.tosatti@cyclades.com, blazara@nvidia.com, netdev@oss.sgi.com
Subject: Re: [PATCH 2.4.28-pre4-bk3] forcedeth: Gigabit ethernet support and media detection changes
Date: Sun, 17 Oct 2004 09:46:31 -0400	[thread overview]
Message-ID: <417277B7.8000705@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0410171216490.29815-100000@dbl.q-ag.de>

Manfred Spraul wrote:
> Backport of the 0.29 forcedeth driver to 2.4.
> Changes:
> - lots of bugfixes.
> - completely rewritten PHY initialization and media detection
> - gigabit ethernet support
> 
> The actual backport was done by Jane Liu from NVIDIA:
> 
> - all occurrences of msleep changed to mdelay

NAK, mdelay(500) isn't acceptable.  Use schedule_timeout or add msleep 
to 2.4.x.


> - SET_NETDEV_DEV calls removed

NAK, SET_NETDEV_DEV() exists in 2.4.x


> - module_param call changed to MODULE_PARM

OK

	Jeff

  parent reply	other threads:[~2004-10-17 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-17 10:27 [PATCH 2.4.28-pre4-bk3] forcedeth: Gigabit ethernet support and media detection changes Manfred Spraul
2004-10-17 13:38 ` Christoph Hellwig
2004-10-17 13:46 ` Jeff Garzik [this message]
2004-10-17 14:10   ` Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=417277B7.8000705@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=blazara@nvidia.com \
    --cc=manfred@colorfullife.com \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).