From: Patrick McHardy <kaber@trash.net>
To: "David S. Miller" <davem@redhat.com>
Cc: netdev@oss.sgi.com, YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: [PATCH 2.6.9]: Fix netdevice/inet6_dev reference leaks in ip6_route_add error paths
Date: Wed, 20 Oct 2004 00:13:54 +0200 [thread overview]
Message-ID: <417591A2.4090201@trash.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 119 bytes --]
The recent changes to ip6_route_add added multiple leaks in
error paths. This patch should fix them.
Regards
Patrick
[-- Attachment #2: p2 --]
[-- Type: text/plain, Size: 1048 bytes --]
# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
# 2004/10/19 23:46:56+02:00 kaber@coreworks.de
# [IPV6]: Fix netdevice/inet6_dev reference leaks in ip6_route_add error paths
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
# net/ipv6/route.c
# 2004/10/19 23:46:17+02:00 kaber@coreworks.de +8 -3
# [IPV6]: Fix netdevice/inet6_dev reference leaks in ip6_route_add error paths
#
# Signed-off-by: Patrick McHardy <kaber@trash.net>
#
diff -Nru a/net/ipv6/route.c b/net/ipv6/route.c
--- a/net/ipv6/route.c 2004-10-19 23:52:23 +02:00
+++ b/net/ipv6/route.c 2004-10-19 23:52:23 +02:00
@@ -798,8 +798,10 @@
rt = ip6_dst_alloc();
- if (rt == NULL)
- return -ENOMEM;
+ if (rt == NULL) {
+ err = -ENOMEM;
+ goto out;
+ }
rt->u.dst.obsolete = -1;
rt->rt6i_expires = clock_t_to_jiffies(rtmsg->rtmsg_info);
@@ -962,7 +964,10 @@
out:
if (dev)
dev_put(dev);
- dst_free((struct dst_entry *) rt);
+ if (idev)
+ in6_dev_put(idev);
+ if (rt)
+ dst_free((struct dst_entry *) rt);
return err;
}
next reply other threads:[~2004-10-19 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-19 22:13 Patrick McHardy [this message]
2004-10-20 6:35 ` [PATCH 2.6.9]: Fix netdevice/inet6_dev reference leaks in ip6_route_add error paths YOSHIFUJI Hideaki / 吉藤英明
2004-10-21 4:22 ` David S. Miller
2004-10-21 5:17 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417591A2.4090201@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=netdev@oss.sgi.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).