From: "Randy.Dunlap" <rddunlap@osdl.org>
To: netdev <netdev@oss.sgi.com>,
davem@davemloft.net, jgarzik <jgarzik@pobox.com>
Subject: [PATCH] tg3: reading eeprom via ethtool: not __init
Date: Tue, 19 Oct 2004 21:28:05 -0700 [thread overview]
Message-ID: <4175E955.6070807@osdl.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 12 bytes --]
--
~Randy
[-- Attachment #2: tg3_init.patch --]
[-- Type: text/x-patch, Size: 1591 bytes --]
tg3_get_eeprom calls: tg3_nvram_read_using_eeprom __init:
but the latter cannot be __init if it can be called (via ethtool)
after driver-init:
Error: ./drivers/net/tg3.o .text refers to 0000000000007220 R_X86_64_PC32 .init.text+0xfffffffffffffffc
Error: ./drivers/net/tg3.o .text refers to 000000000000725d R_X86_64_PC32 .init.text+0xfffffffffffffffc
Error: ./drivers/net/tg3.o .text refers to 00000000000072a7 R_X86_64_PC32 .init.text+0xfffffffffffffffc
Error: ./drivers/net/tg3.o .text refers to 00000000000072e8 R_X86_64_PC32 .init.text+0xfffffffffffffffc
Signed-off-by: Randy Dunlap <rddunlap@osdl.org>
diffstat:=
drivers/net/tg3.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff -Naurp ./drivers/net/tg3.c~tg3_init ./drivers/net/tg3.c
--- ./drivers/net/tg3.c~tg3_init 2004-10-18 14:54:31.000000000 -0700
+++ ./drivers/net/tg3.c 2004-10-19 20:43:44.510473240 -0700
@@ -6319,8 +6319,8 @@ static int tg3_get_eeprom_len(struct net
return EEPROM_CHIP_SIZE;
}
-static int __devinit tg3_nvram_read_using_eeprom(struct tg3 *tp,
- u32 offset, u32 *val);
+static int tg3_nvram_read_using_eeprom(struct tg3 *tp,
+ u32 offset, u32 *val);
static int tg3_get_eeprom(struct net_device *dev, struct ethtool_eeprom *eeprom, u8 *data)
{
struct tg3 *tp = dev->priv;
@@ -6851,8 +6851,8 @@ static void __devinit tg3_nvram_init(str
}
}
-static int __devinit tg3_nvram_read_using_eeprom(struct tg3 *tp,
- u32 offset, u32 *val)
+static int tg3_nvram_read_using_eeprom(struct tg3 *tp,
+ u32 offset, u32 *val)
{
u32 tmp;
int i;
next reply other threads:[~2004-10-20 4:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-20 4:28 Randy.Dunlap [this message]
2004-10-21 4:19 ` [PATCH] tg3: reading eeprom via ethtool: not __init David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4175E955.6070807@osdl.org \
--to=rddunlap@osdl.org \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).