[PATCH] sk98lin: Driver update v7.09

[PATCH] sk98lin: Driver update v7.09

[Mirko Lindner]

Hi dev-list,
Hi Jeff,

here is the new version (v7.09) from our sk98lin driver for Kernel 2.6. 
Sorry for this huge patch but this version has a lot of new functions 
and changes. The driver was tested by our Test & Verification group and 
our OEM customers and include all kernel changes during the latest 
kernel release.

Please send me an email if you like a version of the driver for kernel 
2.4 or if you have any problems or questions.

The new patch for BK version 2.6.9 bk6 can be find at:
http://www.syskonnect.de/support/temp/sk98lin_v7.09_2.6.9-bk6_patch

Cheers
Mirko


======================
Patch 1/1]
[SK98LIN]:
Add: Support for PCI Express based chipsets
Add: Support for Yukon EC chipset
Add: Support for FE chipset
Add: Support for wake on lan
Add: Support for Ethtool
Add: Support for rx polling interface

Re: [PATCH] sk98lin: Driver update v7.09

[Christoph Hellwig]

On Fri, Oct 22, 2004 at 03:14:41PM +0200, Mirko Lindner wrote:
> Hi dev-list,
> Hi Jeff,
> 
> here is the new version (v7.09) from our sk98lin driver for Kernel 2.6. 
> Sorry for this huge patch but this version has a lot of new functions 
> and changes. The driver was tested by our Test & Verification group and 
> our OEM customers and include all kernel changes during the latest 
> kernel release.
> 
> Please send me an email if you like a version of the driver for kernel 
> 2.4 or if you have any problems or questions.
> 
> The new patch for BK version 2.6.9 bk6 can be find at:
> http://www.syskonnect.de/support/temp/sk98lin_v7.09_2.6.9-bk6_patch

Standard disclaimer:  please submit small incremental patches that fix
specific issue.

Re: [PATCH] sk98lin: Driver update v7.09

[Stephen Hemminger]

On Fri, 22 Oct 2004 15:14:41 +0200
Mirko Lindner <mlindner@syskonnect.de> wrote:

> Hi dev-list,
> Hi Jeff,
> 
> here is the new version (v7.09) from our sk98lin driver for Kernel 2.6. 
> Sorry for this huge patch but this version has a lot of new functions 
> and changes. The driver was tested by our Test & Verification group and 
> our OEM customers and include all kernel changes during the latest 
> kernel release.
> 
> Please send me an email if you like a version of the driver for kernel 
> 2.4 or if you have any problems or questions.
> 
> The new patch for BK version 2.6.9 bk6 can be find at:
> http://www.syskonnect.de/support/temp/sk98lin_v7.09_2.6.9-bk6_patch

Since you won't...
I'll break this up in pieces (and merge in my changes), and get
rid of the UglyReDefineTheWorld style.

Re: [PATCH] sk98lin: Driver update v7.09

[Mirko Lindner]

Stephen,

thank You for the help! Should we help you in any case to check or 
change the defines?

We have the problem that the Linux driver consists of multiple files 
which are also used for other drivers running on other OSes
(e.g. Sun, HP-UX, MacOS X, *BSD, Windows, PXE, AIX, Unixware...).

This is for instance the reason why we must use redefines for the
different data types (e.g. SK_U32). Can you please explain what you mean 
with "UglyReDefineTheWorld"? Are there any special defines you do not 
like? I am wondering why the style plays such an important role when 
looking at the driver source. I am not sure what redefines you are 
referring to, but the datatype redefines for example have been in the 
kernel tree for years without any complains.

If you could send us a list about the requested changes you'd like to 
perform, we can help you or provide additional support. We would really 
appreciate it, if you could inform us in advance about those changes,
because the driver was tested extensively in our test&verification 
department and by a considerably amount of OEM vendors. Changing now 
parts of the code may break the driver functionality or the 
functionality of the driver files used on other OSes.

Cheers
  Mirko


Stephen Hemminger wrote:
> On Fri, 22 Oct 2004 15:14:41 +0200
> Mirko Lindner <mlindner@syskonnect.de> wrote:
> 
> 
>>Hi dev-list,
>>Hi Jeff,
>>
>>here is the new version (v7.09) from our sk98lin driver for Kernel 2.6. 
>>Sorry for this huge patch but this version has a lot of new functions 
>>and changes. The driver was tested by our Test & Verification group and 
>>our OEM customers and include all kernel changes during the latest 
>>kernel release.
>>
>>Please send me an email if you like a version of the driver for kernel 
>>2.4 or if you have any problems or questions.
>>
>>The new patch for BK version 2.6.9 bk6 can be find at:
>>http://www.syskonnect.de/support/temp/sk98lin_v7.09_2.6.9-bk6_patch
> 
> 
> Since you won't...
> I'll break this up in pieces (and merge in my changes), and get
> rid of the UglyReDefineTheWorld style.
> 
> 

Re: [PATCH] sk98lin: Driver update v7.09

[Stephen Hemminger]

On Fri, 29 Oct 2004 19:43:09 +0200
Mirko Lindner <mlindner@syskonnect.de> wrote:

> Stephen,
> 
> thank You for the help! Should we help you in any case to check or 
> change the defines?
> 
> We have the problem that the Linux driver consists of multiple files 
> which are also used for other drivers running on other OSes
> (e.g. Sun, HP-UX, MacOS X, *BSD, Windows, PXE, AIX, Unixware...).
> 
> This is for instance the reason why we must use redefines for the
> different data types (e.g. SK_U32). Can you please explain what you mean 
> with "UglyReDefineTheWorld"? Are there any special defines you do not 
> like? I am wondering why the style plays such an important role when 
> looking at the driver source. I am not sure what redefines you are 
> referring to, but the datatype redefines for example have been in the 
> kernel tree for years without any complains.

Style matters especially things like:

#define SK_NET_DEVICE	net_device
#define SK_IOC			char __iomem *

because it means that source code inspection tools like cscope will
not easily pickup all usages of the structure when developers need to
do audit's to change interfaces.

My goal is to make all the linux only pieces look as close to linux style
as possible without going to the extreme of changing variable names and
function names.

The common parts will not be touched at all. My plan will be to make
one of the patch steps up these in one chunk.


> If you could send us a list about the requested changes you'd like to 
> perform, we can help you or provide additional support. We would really 
> appreciate it, if you could inform us in advance about those changes,
> because the driver was tested extensively in our test&verification 
> department and by a considerably amount of OEM vendors. Changing now 
> parts of the code may break the driver functionality or the 
> functionality of the driver files used on other OSes.
> 
> Cheers
>   Mirko

So far I have about 10 patches done, and most of the way through getting ethtool
working using your code. EMany ethtool functions needed minor work to resolve
issues like not checking parameters and error handling.

Re: [PATCH] sk98lin: Driver update v7.09

[Mirko Lindner]

On Fri, Oct 22, 2004 at 03:14:41PM +0200, Mirko Lindner wrote:
 >> Hi dev-list,
 >> Hi Jeff,
 >>
 >> here is the new version (v7.09) from our sk98lin driver for Kernel 2.6.
 >> Sorry for this huge patch but this version has a lot of new functions
 >> and changes. The driver was tested by our Test & Verification group and
 >> our OEM customers and include all kernel changes during the latest
 >> kernel release.
 >>
 >> Please send me an email if you like a version of the driver for kernel
 >> 2.4 or if you have any problems or questions.
 >>
 >> The new patch for BK version 2.6.9 bk6 can be find at:
 >> http://www.syskonnect.de/support/temp/sk98lin_v7.09_2.6.9-bk6_patch

 > Standard disclaimer:  please submit small incremental patches that fix
 > specific issue.


Sorry for the big patch but it's not possible to split the driver into
small pieces. As mentioned the submission isn't a bugfix release of the
old v6 driver with small additions. The new version 7.09 is a new driver
based on the old sk98lin driver with a support for two new chipsets from
Marvell (Yukon EC and Yukon FE). Yes, I know. The patch is huge but the
Yukon chipset has a different buffer handling and many register and hw
changes

I will be out of the office till Thursday. After the LWE we will merge
the new changes from Stephen into the new driver version. We have also
small fixes for the 7.09 and I think I'll release the 7.10 at the end of
the next week.

Mirko