From: Jeff Garzik <jgarzik@pobox.com>
To: Dan Williams <dcbw@redhat.com>
Cc: netdev@oss.sgi.com, jgarzik@redhat.com, hermes@gibson.dropbear.id.au
Subject: Re: [PATCH 2.6.10-rc1 1/15] wireless/orinoco: Use msleep() instead of hardcoded schedule_timeout()s
Date: Tue, 26 Oct 2004 15:34:20 -0400 [thread overview]
Message-ID: <417EA6BC.5020208@pobox.com> (raw)
In-Reply-To: <1098815604.3663.35.camel@dcbw.boston.redhat.com>
Dan Williams wrote:
> --- a/drivers/net/wireless/airport.c.1-msleep 2004-10-25 14:44:04.559958488 -0400
> +++ b/drivers/net/wireless/airport.c 2004-10-25 14:44:51.372841848 -0400
> @@ -28,7 +28,6 @@
> #include <linux/if_arp.h>
> #include <linux/etherdevice.h>
> #include <linux/wireless.h>
> -#include <linux/delay.h>
>
> #include <asm/io.h>
> #include <asm/system.h>
> @@ -147,7 +146,7 @@
> macio_release_resource(mdev, 0);
>
> pmac_call_feature(PMAC_FTR_AIRPORT_ENABLE, macio_get_of_node(mdev), 0, 0);
> - ssleep(1);
> + msleep(1000);
>
> macio_set_drvdata(mdev, NULL);
> free_netdev(dev);
> @@ -173,12 +172,12 @@
> disable_irq(dev->irq);
>
> pmac_call_feature(PMAC_FTR_AIRPORT_ENABLE, macio_get_of_node(card->mdev), 0, 0);
> - ssleep(1);
> + msleep(1000);
> pmac_call_feature(PMAC_FTR_AIRPORT_ENABLE, macio_get_of_node(card->mdev), 0, 1);
> - ssleep(1);
> + msleep(1000);
>
> enable_irq(dev->irq);
> - ssleep(1);
> + msleep(1000);
> #endif
>
> return 0;
> @@ -237,7 +236,7 @@
>
> /* Power up card */
> pmac_call_feature(PMAC_FTR_AIRPORT_ENABLE, macio_get_of_node(mdev), 0, 1);
> - ssleep(1);
> + msleep(1000);
>
> /* Reset it before we get the interrupt */
> hermes_init(hw);
these changes are all regressions
> --- a/drivers/net/wireless/orinoco_cs.c.1-msleep 2004-10-25 14:44:04.558958640 -0400
> +++ b/drivers/net/wireless/orinoco_cs.c 2004-10-25 14:44:51.374841544 -0400
> @@ -136,6 +136,7 @@
> if (err)
> return err;
>
> + msleep(100);
> clear_bit(0, &card->hard_reset_in_progress);
>
> return 0;
> --- a/drivers/net/wireless/orinoco_plx.c.1-msleep 2004-10-25 14:44:04.559958488 -0400
> +++ b/drivers/net/wireless/orinoco_plx.c 2004-10-25 14:44:51.376841240 -0400
> @@ -352,8 +352,7 @@
> static void __exit orinoco_plx_exit(void)
> {
> pci_unregister_driver(&orinoco_plx_driver);
> - current->state = TASK_UNINTERRUPTIBLE;
> - schedule_timeout(HZ);
> + msleep(1000);
> }
>
> module_init(orinoco_plx_init);
> --- a/drivers/net/wireless/orinoco_tmd.c.1-msleep 2004-10-25 14:44:04.557958792 -0400
> +++ b/drivers/net/wireless/orinoco_tmd.c 2004-10-25 14:44:51.377841088 -0400
> @@ -218,8 +218,7 @@
> static void __exit orinoco_tmd_exit(void)
> {
> pci_unregister_driver(&orinoco_tmd_driver);
> - current->state = TASK_UNINTERRUPTIBLE;
> - schedule_timeout(HZ);
> + msleep(1000);
use ssleep() not msleep()
next prev parent reply other threads:[~2004-10-26 19:34 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-26 18:12 [PATCHES] wireless: Update in-kernel orinoco driver Dan Williams
2004-10-26 18:33 ` [PATCH 2.6.10-rc1 1/15] wireless/orinoco: Use msleep() instead of hardcoded schedule_timeout()s Dan Williams
2004-10-26 18:47 ` Christoph Hellwig
2004-10-26 19:35 ` Dan Williams
2004-10-26 19:42 ` Christoph Hellwig
2004-10-26 19:55 ` Dan Williams
2004-10-27 3:13 ` David Gibson
2004-10-27 13:11 ` Dan Williams
2004-10-28 1:42 ` David Gibson
2004-10-26 19:34 ` Jeff Garzik [this message]
2004-10-26 18:38 ` [PATCH 2.6.10-rc1 1/15] wireless/orinoco: use msleep() Dan Williams
2004-10-26 18:39 ` [PATCH 2.6.10-rc1 2/15] wireless/orinoco: fix up printk text Dan Williams
2004-10-26 18:43 ` [PATCH 2.6.10-rc1 3/15] wireless/orinoco: encapsulate direct hardware operations Dan Williams
2004-10-27 3:15 ` David Gibson
2004-10-26 18:45 ` [PATCH 2.6.10-rc1 4/15] wireless/orinoco: Update orinoco changelog and module parameters Dan Williams
2004-10-26 19:36 ` Jeff Garzik
2004-10-27 3:15 ` David Gibson
2004-10-26 18:47 ` [PATCH 2.6.10-rc1 5/15] wireless/orinoco: Update orinoco pcmcia driver's IRQ handling Dan Williams
2004-10-26 18:51 ` [PATCH 2.6.10-rc1 6/15] wireless/orinoco: New device data release function Dan Williams
2004-10-26 18:56 ` [PATCH 2.6.10-rc1 7/15] wireless/orinoco: Update card reset/init code and add card-specific data structures Dan Williams
2004-10-26 19:43 ` Jeff Garzik
2004-10-27 4:00 ` David Gibson
2004-10-26 19:04 ` R[PATCH 2.6.10-rc1 8/15] wireless/orinoco: Refactor spinlocks so we don't necessarily have to disable interrupts Dan Williams
2004-10-26 19:44 ` Jeff Garzik
2004-10-27 4:14 ` David Gibson
2004-10-26 19:07 ` [PATCH 2.6.10-rc1 9/15] wireless/orinoco: Remove dump_recs in preparation for a more flexible replacement Dan Williams
2004-10-26 19:13 ` [PATCH 2.6.10-rc1 10/15] wireless/orinoco: Use wireless handlers rather than ioctl()s Dan Williams
2004-10-26 19:18 ` [PATCH 2.6.10-rc1 11/15] wireless/orinoco: Clean up firmware version & capability detection Dan Williams
2004-10-26 19:20 ` [PATCH 2.6.10-rc1 12/15] wireless/orinoco: Use netif routines rather than keeping link state ourselves Dan Williams
2004-10-26 19:22 ` [PATCH 2.6.10-rc1 13/15] wireless/orinoco: RF monitor mode support Dan Williams
2004-10-26 19:24 ` [PATCH 2.6.10-rc1 14/15] wireless/orinoco: add minimal ethtool support Dan Williams
2004-10-26 19:46 ` Jeff Garzik
2004-10-27 4:01 ` David Gibson
2004-10-26 19:28 ` [PATCH 2.6.10-rc1 15/15] wireless/orinoco: Wireless scanning support Dan Williams
2004-10-26 19:33 ` Francois Romieu
2004-10-27 4:06 ` David Gibson
2004-10-27 2:05 ` [PATCHES] wireless: Update in-kernel orinoco driver David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=417EA6BC.5020208@pobox.com \
--to=jgarzik@pobox.com \
--cc=dcbw@redhat.com \
--cc=hermes@gibson.dropbear.id.au \
--cc=jgarzik@redhat.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).