From: Jeff Garzik <jgarzik@pobox.com>
To: janitor@sternwelten.at
Cc: netdev@oss.sgi.com, nacc@us.ibm.com
Subject: Re: [patch 10/18] net/g96100eth: replace gt96100_delay() with msleep_interruptible()
Date: Sun, 31 Oct 2004 06:06:23 -0500 [thread overview]
Message-ID: <4184C72F.8000905@pobox.com> (raw)
In-Reply-To: <E1CO1vu-0002Lf-5c@sputnik>
janitor@sternwelten.at wrote:
> @@ -528,7 +517,7 @@ abort(struct net_device *dev, u32 abort_
> // wait for abort to complete
> while (GT96100ETH_READ(gp, GT96100_ETH_SDMA_COMM) & abort_bits) {
> // snooze for 20 msec and check again
> - gt96100_delay(1);
> + msleep_interruptible(20);
>
> if (--timedout == 0) {
don't change the behavior of the driver, even if it disagrees with the
comment.
next prev parent reply other threads:[~2004-10-31 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-30 22:42 [patch 10/18] net/g96100eth: replace gt96100_delay() with msleep_interruptible() janitor
2004-10-31 11:06 ` Jeff Garzik [this message]
2004-11-01 19:08 ` [PATCH] net/gt96100eth: " Nishanth Aravamudan
2004-11-05 7:47 ` Jeff Garzik
2004-11-05 17:46 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4184C72F.8000905@pobox.com \
--to=jgarzik@pobox.com \
--cc=janitor@sternwelten.at \
--cc=nacc@us.ibm.com \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).