netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: netdev@oss.sgi.com, rl@hellgate.ch
Subject: [PATCH] via-rhine: references __init code during resume
Date: Mon, 01 Nov 2004 09:21:48 -0800	[thread overview]
Message-ID: <418670AC.7010801@osdl.org> (raw)
In-Reply-To: <418390F2.7080901@pobox.com>

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

[Does it work if the patch description is inline & the
patch is attached?]


Fix __init section usage:
rhine_resume calls enable_mmio, so latter cannot be __devinit;
Error: ./drivers/net/via-rhine.o .text refers to 0000000000000925 
R_X86_64_PC32     .init.text+0xfffffffffffffffc

Signed-off-by: Randy Dunlap <rddunlap@osdl.org>

diffstat:=
  drivers/net/via-rhine.c |    2 +-
  1 files changed, 1 insertion(+), 1 deletion(-)

-- 
~Randy

[-- Attachment #2: via_rhine_mmio.patch --]
[-- Type: text/x-patch, Size: 460 bytes --]

diff -Naurp ./drivers/net/via-rhine.c~via_rhine_mmio ./drivers/net/via-rhine.c
--- ./drivers/net/via-rhine.c~via_rhine_mmio	2004-10-18 14:55:28.000000000 -0700
+++ ./drivers/net/via-rhine.c	2004-10-22 10:10:58.928311448 -0700
@@ -627,7 +627,7 @@ static void rhine_chip_reset(struct net_
 }
 
 #ifdef USE_MMIO
-static void __devinit enable_mmio(long pioaddr, u32 quirks)
+static void enable_mmio(long pioaddr, u32 quirks)
 {
 	int n;
 	if (quirks & rqRhineI) {

  reply	other threads:[~2004-11-01 17:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-22 18:41 [PATCH] via-rhine: references __init code during resume Randy.Dunlap
2004-10-30 13:02 ` Jeff Garzik
2004-11-01 17:21   ` Randy.Dunlap [this message]
2004-11-05  7:57     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=418670AC.7010801@osdl.org \
    --to=rddunlap@osdl.org \
    --cc=jgarzik@pobox.com \
    --cc=netdev@oss.sgi.com \
    --cc=rl@hellgate.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).