[PATCH 2.6]: Fix device leaks in mirred action

[Patrick McHardy <kaber@trash.net>]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

When a mirred action is created it takes two references to the
device (dev_get_by_index + dev_hold), but only drops one when
it gets destroyed. It also leaks a reference when a mirred action
is replaced.



[-- Attachment #2: x --]
[-- Type: text/plain, Size: 793 bytes --]

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/11/04 07:28:30+01:00 kaber@coreworks.de 
#   [PKT_SCHED]: Fix device leaks in mirred action
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
# net/sched/mirred.c
#   2004/11/04 07:28:24+01:00 kaber@coreworks.de +2 -1
#   [PKT_SCHED]: Fix device leaks in mirred action
#   
#   Signed-off-by: Patrick McHardy <kaber@trash.net>
# 
diff -Nru a/net/sched/mirred.c b/net/sched/mirred.c
--- a/net/sched/mirred.c	2004-11-04 07:28:59 +01:00
+++ b/net/sched/mirred.c	2004-11-04 07:28:59 +01:00
@@ -138,8 +138,9 @@
 		p->eaction = parm->eaction;
 		if (parm->ifindex) {
 			p->ifindex = parm->ifindex;
+			if (ovr)
+				dev_put(p->dev);
 			p->dev = dev;
-			dev_hold(p->dev); 
 		}
 		spin_unlock(&p->lock);
 	}