From: Patrick McHardy <kaber@trash.net>
To: hadi@cyberus.ca
Cc: "David S. Miller" <davem@redhat.com>, netdev@oss.sgi.com
Subject: Re: [PATCH 2.6]: Fix device leaks in mirred action
Date: Thu, 04 Nov 2004 15:58:39 +0100 [thread overview]
Message-ID: <418A439F.2010401@trash.net> (raw)
In-Reply-To: <1099576439.1038.147.camel@jzny.localdomain>
jamal wrote:
>>It also leaks a reference when a mirred action
>>is replaced.
>>
>>
>
>How? Is this patch supposed to fix that?
>
>
+ if (ovr)
+ dev_put(p->dev);
p->dev = dev;
By dropping the reference before replacing it.
Regards
Patrick
next prev parent reply other threads:[~2004-11-04 14:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-04 6:30 [PATCH 2.6]: Fix device leaks in mirred action Patrick McHardy
2004-11-04 13:53 ` jamal
2004-11-04 14:58 ` Patrick McHardy [this message]
2004-11-04 15:23 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418A439F.2010401@trash.net \
--to=kaber@trash.net \
--cc=davem@redhat.com \
--cc=hadi@cyberus.ca \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).