netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ulrich Weber <uweber@astaro.de>
To: Patrick McHardy <kaber@trash.net>
Cc: vpn-failover@lists.balabit.hu, netdev@oss.sgi.com,
	ipsec-tools-devel@lists.sourceforge.net
Subject: Re: [Vpn-failover] [RFC] IPSEC failover - Netlink part
Date: Tue, 09 Nov 2004 09:55:05 +0100	[thread overview]
Message-ID: <419085E9.4060209@astaro.de> (raw)
In-Reply-To: <418F9A70.7040400@trash.net>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

|> |> +    NLMSG_LENGTH(sizeof(struct xfrm_usersa_id)),/* UPD SEQ */
|> |>
|> |>
|> | ^^ what about struct xfrm_replay_state ?
|> it's attached as rt attribute, so it should be ok.
|
| But you don't check it's size. You need to include it here or check it
| when you use it.
ok i added the following checkt to ensure the right size.

If i add the size of the xfrm_replay_state struct to the above array, the rt
attribute macros wouldnt work anymore.


Cheers
~ Ulrich

- ----
struct rtattr *rt = xfrma[XFRMA_REPLAY-1];

if( xfrma[XFRMA_REPLAY-1] && (rt->rta_len == (sizeof(struct
xfrm_replay_state) + sizeof(struct rtattr)))) {
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFBkIXp22t2oTuElzoRAqsnAJ9QlZuU6wBWtmkzcT8aeb9+AL3nfQCfZUeI
EJh0+e8EOS4/HKiP2Ylu02k=
=roZY
-----END PGP SIGNATURE-----

      reply	other threads:[~2004-11-09  8:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-29 10:23 [RFC] IPSEC failover and replay detection sequence numbers KOVACS Krisztian
2004-10-29 12:58 ` jamal
2004-10-29 13:24   ` KOVACS Krisztian
2004-10-29 15:01     ` jamal
2004-10-29 16:15       ` KOVACS Krisztian
2004-11-07 17:42   ` Michael Richardson
2004-11-04 14:01 ` [Vpn-failover] [RFC] IPSEC failover - Netlink part Ulrich Weber
2004-11-04 18:15   ` Patrick McHardy
2004-11-08 10:31     ` Ulrich Weber
2004-11-08 16:10       ` Patrick McHardy
2004-11-09  8:55         ` Ulrich Weber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=419085E9.4060209@astaro.de \
    --to=uweber@astaro.de \
    --cc=ipsec-tools-devel@lists.sourceforge.net \
    --cc=kaber@trash.net \
    --cc=netdev@oss.sgi.com \
    --cc=vpn-failover@lists.balabit.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).