[PATCH] convert sis900 to new style parameters

[PATCH] convert sis900 to new style parameters

[Daniele Venzano]

[-- Attachment #1.1: Type: text/plain, Size: 483 bytes --]

The attached patch converts MODULE_PARM() calls in module_param() calls.
I've tested it and the expected files were created in sysfs.

For now all parameters are read-only. After some check I'll probably
change some of them to r/w.

The patch is against 2.6.9 and if no issues are raised, I propose it for
inclusion.

This patch is also available at http://teg.homeunix.org/sis900.html

-- 
-----------------------------
Daniele Venzano
Web: http://teg.homeunix.org


[-- Attachment #1.2: sis900-module-param.diff --]
[-- Type: text/plain, Size: 910 bytes --]

--- a/drivers/net/sis900.c	2004-11-12 16:26:50.000000000 +0100
+++ b/drivers/net/sis900.c	2004-11-12 16:33:20.000000000 +0100
@@ -48,6 +48,7 @@
 */
 
 #include <linux/module.h>
+#include <linux/moduleparam.h>
 #include <linux/kernel.h>
 #include <linux/string.h>
 #include <linux/timer.h>
@@ -179,9 +180,9 @@
 MODULE_DESCRIPTION("SiS 900 PCI Fast Ethernet driver");
 MODULE_LICENSE("GPL");
 
-MODULE_PARM(multicast_filter_limit, "i");
-MODULE_PARM(max_interrupt_work, "i");
-MODULE_PARM(debug, "i");
+module_param(multicast_filter_limit, int, 0444);
+module_param(max_interrupt_work, int, 0444);
+module_param(debug, int, 0444);
 MODULE_PARM_DESC(multicast_filter_limit, "SiS 900/7016 maximum number of filtered multicast addresses");
 MODULE_PARM_DESC(max_interrupt_work, "SiS 900/7016 maximum events handled per interrupt");
 MODULE_PARM_DESC(debug, "SiS 900/7016 debug level (2-4)");

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [PATCH] convert sis900 to new style parameters

[Jeff Garzik]

Patch is OK, but your mailer sends them "MIME-encrypted", which means 
script (like the ones I use) cannot merge the patch.

Example from your email:
> @@ -179,9 +180,9 @@
>  MODULE_DESCRIPTION("SiS 900 PCI Fast Ethernet driver");
>  MODULE_LICENSE("GPL");
> =20
> -MODULE_PARM(multicast_filter_limit, "i");
> -MODULE_PARM(max_interrupt_work, "i");
> -MODULE_PARM(debug, "i"); 
> +module_param(multicast_filter_limit, int, 0444);
> +module_param(max_interrupt_work, int, 0444);
> +module_param(debug, int, 0444);
>  MODULE_PARM_DESC(multicast_filter_limit, "SiS 900/7016 maximum number of f=
> iltered multicast addresses");
>  MODULE_PARM_DESC(max_interrupt_work, "SiS 900/7016 maximum events handled =
> per interrupt");
>  MODULE_PARM_DESC(debug, "SiS 900/7016 debug level (2-4)");