From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: netdev@vger.kernel.org
Cc: Eric Dumazet <edumazet@kernel.org>,
Neal Cardwell <ncardwell@google.com>,
Kuniyuki Iwashima <kuniyu@google.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Soheil Hassas Yeganeh <soheil@google.com>,
Shakeel Butt <shakeel.butt@linux.dev>,
Wei Wang <weiwan@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] tcp: fix negative sk_forward_alloc after MSG_ZEROCOPY append
Date: Fri, 20 Nov 2026 18:09:09 +0800 [thread overview]
Message-ID: <4198a993-1c7c-4ca5-8d31-8f8e36778702@linux.dev> (raw)
In-Reply-To: <20261120094605.46063-1-jiayuan.chen@linux.dev>
On 11/20/26 5:46 PM, Jiayuan Chen wrote:
> Our local syzbot reported the following warning:
>
> WARNING: ./include/linux/ucopysize.h:57 at tcp_sendmsg_locked+0x1e13/0x1f20
> Modules linked in:
> CPU: 3 UID: 0 PID: 377 Comm: syz.2.2248 Not tainted 7.4.0-rc2+ #398 PREEMPT
> RIP: 0010:tcp_sendmsg_locked+0x1e13/0x1f20
> Call Trace:
> <TASK>
> tcp_sendmsg+0x2c/0x50
> inet_sendmsg+0x62/0xb0
> __sys_sendto+0x2fe/0x350
> __x64_sys_sendto+0x7f/0xb0
> x64_sys_call+0x1375/0x27e0
> do_syscall_64+0xe4/0x470
> entry_SYSCALL_64_after_hwframe+0x76/0x7e
> </TASK>
>
> The problem is here:
>
> if (!skb_zcopy_pure(skb)) {
> copy = tcp_wmem_schedule(sk, copy);
> if (!copy)
> goto wait_for_space;
> }
>
> When MSG_ZEROCOPY data is appended to a skb that already holds copied
> data, only the user length is scheduled, but the pinned pages are then
> charged by their truesize:
>
> skb_zerocopy_iter_stream
> __zerocopy_sg_from_iter
> zerocopy_fill_skb_from_iter //truesize += PAGE_ALIGN(copied + start)
> sk_mem_charge(sk, truesize) //sk_forward_alloc goes negative
>
> For example, sending 8 iovecs of 1 byte each schedules 8 bytes and
> charges 32768 with 4K pages.
>
> On a later sendmsg() without MSG_ZEROCOPY, if sk_wmem_schedule() fails
> (e.g. tcp_mem hard limit is reached), tcp_wmem_schedule() returns
> min(copy, sk->sk_forward_alloc), which is negative. The negative copy
> is passed to skb_copy_to_page_nocache() and triggers the warning, and
> sendmsg() fails with -EFAULT.
>
> A few options were considered:
>
> 1) Schedule the truesize up front. It is not known before the pages
> are pinned, it depends on the iovec layout.
> 2) Do not append zerocopy data to a non pure skb. This splits a small
> header and its zerocopy payload into two skbs.
> 3) Schedule the missing part right after the pages are charged. They
> are already in the skb at this point, so this can not fail.
>
> Go with 3).
>
> Fixes: 849b425cd091 ("tcp: fix possible freeze in tx path under memory pressure")
> Signed-off-by: Jiayuan Chen <jiayuan.chen@linux.dev>
> ---
> v1: https://lore.kernel.org/netdev/20261119090828.343748-1-jiayuan.chen@linux.dev/
>
> Changes in v2:
> - Only call sk_forced_mem_schedule() for non pure zerocopy skbs (Eric)
> ---
> net/ipv4/tcp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c
> index d510e982dcea..343f6d61b408 100644
> --- a/net/ipv4/tcp.c
> +++ b/net/ipv4/tcp.c
> @@ -1359,6 +1359,8 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size)
> if (err < 0)
> goto do_error;
> copy = err;
> + if (!skb_zcopy_pure(skb))
> + sk_forced_mem_schedule(sk, 0);
I think I should move such code before the 'if (err < 0)', like the sashiko said:
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261119090828.343748-1-jiayuan.chen%40linux.dev
> } else if (zc == MSG_SPLICE_PAGES) {
> /* Splice in data if we can; copy if we can't. */
> if (tcp_downgrade_zcopy_pure(sk, skb))
prev parent reply other threads:[~2026-11-20 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 9:46 [PATCH net v2] tcp: fix negative sk_forward_alloc after MSG_ZEROCOPY append Jiayuan Chen
2026-11-20 10:09 ` Jiayuan Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4198a993-1c7c-4ca5-8d31-8f8e36778702@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shakeel.butt@linux.dev \
--cc=soheil@google.com \
--cc=weiwan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox